Closed Bug 1577518 Opened 1 year ago Closed 5 months ago

Upgrade Thunderbird's libgcrypt to 1.8.5

Categories

(Chat Core :: General, task)

task
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Instantbird 77

People

(Reporter: KaiE, Assigned: rjl)

References

Details

Attachments

(2 files, 2 obsolete files)

libgcrypt 1.8.5 has been announced:
https://lists.gnupg.org/pipermail/gnupg-announce/2019q3/000440.html

The currently provided binaries, and the source code checked is version 1.8.4

We only use libgcrypt for OTR, and OTR doesn't use ECDSA in my understanding, so we aren't in a hurry. I'll upgrade the libs at a good opportunity.

FYI, the current linux64 build is not "stripped", the others are. I only caught it because the file size was 4x larger.

libgpg-error 1.37 is also available as of a couple of weeks ago.

Attached patch libgcrypt-1.8.5.patch (obsolete) — Splinter Review
Assignee: nobody → rob
Attachment #9143844 - Flags: review?(kaie)
Attached patch libgpg-error-1.37.patch (obsolete) — Splinter Review
Attachment #9143845 - Flags: review?(kaie)
Status: NEW → ASSIGNED
Comment on attachment 9143844 [details] [diff] [review]
libgcrypt-1.8.5.patch

This patch is incomplete.
It misses changes in the doc directory.

Files /home/user/gnupg/libgcrypt-1.8.5/doc/fips-fsm.pdf and third_party/libgcrypt/doc/fips-fsm.pdf differ
Files /home/user/gnupg/libgcrypt-1.8.5/doc/gcrypt.info-1 and third_party/libgcrypt/doc/gcrypt.info-1 differ
Files /home/user/gnupg/libgcrypt-1.8.5/doc/gcrypt.info-2 and third_party/libgcrypt/doc/gcrypt.info-2 differ
Files /home/user/gnupg/libgcrypt-1.8.5/doc/libgcrypt-modules.pdf and third_party/libgcrypt/doc/libgcrypt-modules.pdf differ
Attachment #9143844 - Flags: review?(kaie) → review-
Comment on attachment 9143845 [details] [diff] [review]
libgpg-error-1.37.patch

This patch has problems.

I get a warning when applying:
$ git apply /tmp/libgpg-error-1.37.patch
/tmp/libgpg-error-1.37.patch:21778: trailing whitespace.
libgpg-error.la: $(libgpg_error_la_OBJECTS) $(libgpg_error_la_DEPENDENCIES) $(EXTRA_libgpg_error_la_DEPENDENCIES) 
warning: 1 line adds whitespace errors.

After applying, doc and localization files show differences.
Files /home/user/gnupg/libgpg-error-1.37/doc/gpgrt.info and third_party/libgpg-error/doc/gpgrt.info differ
Files /home/user/gnupg/libgpg-error-1.37/po/cs.gmo and third_party/libgpg-error/po/cs.gmo differ
Files /home/user/gnupg/libgpg-error-1.37/po/da.gmo and third_party/libgpg-error/po/da.gmo differ
Files /home/user/gnupg/libgpg-error-1.37/po/de.gmo and third_party/libgpg-error/po/de.gmo differ
Files /home/user/gnupg/libgpg-error-1.37/po/eo.gmo and third_party/libgpg-error/po/eo.gmo differ
Files /home/user/gnupg/libgpg-error-1.37/po/es.gmo and third_party/libgpg-error/po/es.gmo differ
Files /home/user/gnupg/libgpg-error-1.37/po/fr.gmo and third_party/libgpg-error/po/fr.gmo differ
Files /home/user/gnupg/libgpg-error-1.37/po/hu.gmo and third_party/libgpg-error/po/hu.gmo differ
Files /home/user/gnupg/libgpg-error-1.37/po/it.gmo and third_party/libgpg-error/po/it.gmo differ
Files /home/user/gnupg/libgpg-error-1.37/po/ja.gmo and third_party/libgpg-error/po/ja.gmo differ
Files /home/user/gnupg/libgpg-error-1.37/po/nl.gmo and third_party/libgpg-error/po/nl.gmo differ
Files /home/user/gnupg/libgpg-error-1.37/po/pl.gmo and third_party/libgpg-error/po/pl.gmo differ
Files /home/user/gnupg/libgpg-error-1.37/po/pt.gmo and third_party/libgpg-error/po/pt.gmo differ
Files /home/user/gnupg/libgpg-error-1.37/po/ro.gmo and third_party/libgpg-error/po/ro.gmo differ
Files /home/user/gnupg/libgpg-error-1.37/po/ru.gmo and third_party/libgpg-error/po/ru.gmo differ
Files /home/user/gnupg/libgpg-error-1.37/po/sr.gmo and third_party/libgpg-error/po/sr.gmo differ
Files /home/user/gnupg/libgpg-error-1.37/po/sv.gmo and third_party/libgpg-error/po/sv.gmo differ
Files /home/user/gnupg/libgpg-error-1.37/po/uk.gmo and third_party/libgpg-error/po/uk.gmo differ
Files /home/user/gnupg/libgpg-error-1.37/po/vi.gmo and third_party/libgpg-error/po/vi.gmo differ
Files /home/user/gnupg/libgpg-error-1.37/po/zh_CN.gmo and third_party/libgpg-error/po/zh_CN.gmo differ
Files /home/user/gnupg/libgpg-error-1.37/po/zh_TW.gmo and third_party/libgpg-error/po/zh_TW.gmo differ
Attachment #9143845 - Flags: review?(kaie) → review-
Attachment #9143845 - Attachment is obsolete: true
Attachment #9143910 - Flags: review?(rob)
Attachment #9143844 - Attachment is obsolete: true
Attachment #9143912 - Flags: review?(rob)
Comment on attachment 9143910 [details] [diff] [review]
1577518-libgpg-error-1.37-v2.patch

Review of attachment 9143910 [details] [diff] [review]:
-----------------------------------------------------------------

I see what happened; my patch export did not include the binary files there's just a line saying that it changed.
So I did a 3-way compare of:
- The contents of the downloaded tar file
- My version of the patch (with the binary files changed)
- Your version of the patch applied
And found zero differences. So at least our processes aside from how to share changes for review work.

One thing, your patch does not update README.libgpg-error. Are you doing that separately?
Attachment #9143910 - Flags: review?(rob) → review+
Comment on attachment 9143912 [details] [diff] [review]
1577518-libgcrypt-1.85-v2.patch

Review of attachment 9143912 [details] [diff] [review]:
-----------------------------------------------------------------

Same problem as the libgpg-error patch, I didn't export my patch properly. I did the same 3-way comparison and found no differences except that there is no update to README.libgcrypt in this version.
Attachment #9143912 - Flags: review?(rob) → review+

Thanks for double checking, and sorry, I had missed that you changed the README files.
r=me on your changes to the README files.

Pushed by thunderbird@calypsoblue.org:
https://hg.mozilla.org/comm-central/rev/39e1d01fb0c3
Update libgcrypt to version 1.8.5. r=kaie
https://hg.mozilla.org/comm-central/rev/d4620da6042f
Update libgpg-error to version 1.37. r=kaie

Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → Instantbird 77

Thanks Rob, the code that was checked in matches the archives that I've verified.

You need to log in before you can comment on or make changes to this bug.