1577589 - [wayland] popover arrow is positioned incorrectly when library button is placed on left side of address bar

Status: RESOLVED WORKSFORME

(Core :: Widget: Gtk, defect, P2)

Description

[Asif Youssuff]

Attachment: bad-library-next-to-home-left.png

Steps to reproduce:

1. Enter customize view and drag the library button to left side of address bar
2. Click library button

What happens:

The popover arrow is positioned to the right of the button.

Expected result:

The popover arrow should appear directly below the button clicked, not to the left or right of it.

5:51.96 INFO: No more inbound revisions, bisection finished.
5:51.96 INFO: Last good revision: e8b8985aa697ef4dad6ed72957186c658669bc1d
5:51.96 INFO: First bad revision: 7d383b757d50494cb68ba7b1129d6457765a3314
5:51.96 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=e8b8985aa697ef4dad6ed72957186c658669bc1d&tochange=7d383b757d50494cb68ba7b1129d6457765a3314

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Jan, can you look at it? We should respect the left/right popup placement here. Thanks.

Comment 2

[Ari]

I'm having this issue.

Ubuntu 20.10. Gnome 3.38.3. FF 86.0 (64-bit).

Comment 3

[Jan Horak [:jhorak]]

Sliding arrow is not moved under wayland: https://searchfox.org/mozilla-central/source/layout/xul/nsMenuPopupFrame.cpp#1601 We could revisit the code to look for opportunities how to reintroduce the code in wayland.

Comment 4

[Martin Stránský [:stransky] (ni? me)]

Can you please test latest nightly under Wayland? A new popup handling code landed there.
Thanks.

Comment 5

[Martin Stránský [:stransky] (ni? me)]

Please re-test with new nightly as it gets another popup fixes.
Thanks.

Comment 6

[Ari]

Technically, with the new design, there is no popover arrow. But, the menus still seem to be offset too much. 91.0a1 (2021-06-16) (64-bit).

Comment 7

[Martin Stránský [:stransky] (ni? me)]

(In reply to Ari from comment #6)

Technically, with the new design, there is no popover arrow. But, the menus still seem to be offset too much. 91.0a1 (2021-06-16) (64-bit).

Can you attach a screenshot of it?
Thanks.

Comment 8

[Ari]

Sure thing, here is a screenshot.

Screenshot

Please keep me posted if you need anything else.

Comment 9

[Martin Stránský [:stransky] (ni? me)]

I see. I think we use wrong (too big) anchor here.

Comment 10

[Martin Stránský [:stransky] (ni? me)]

With proton theme the anchor arrow are not painted any more so we can close it.