1577657 - Address MSVC warning C4312

Status: RESOLVED DUPLICATE of bug 1573097

(NSS :: Libraries, defect, P3)

Description

[Martin Thomson [:mt:]]

c:\code\nss\lib\ckfw\instance.c(796): warning C4312: 'type cast': conversion from 'CK_OBJECT_HANDLE' to 'const void *' of greater size

Right now, these warnings are not especially common, but there are a few files that generate quite a few. The problem is that we are putting an integer value into pointer slot. We do that to avoid an allocation (and the associated management). But we need to do two things:

1. Ensure that CK_OBJECT_HANDLE (or whatever type is used) fits in void* with PR_STATIC_ASSERT.

2. Wrap all these conversions with a macro that converts via uintptr_t.

3. Turn these warnings into errors so we don't get more of them.

This is largely mechanical.

Comment 1

[Martin Thomson [:mt:]]

Attachment: The complete set of warnings

The complete set of warnings isn't that long:

```

Comment 2

[Martin Thomson [:mt:]]

I have a habit of opening duplicates of my own bugs.