1577715 - [Search] Ebay search engine is not listed in the "One-click search engines" list after restart

Status: RESOLVED FIXED

(Firefox :: Search, defect, P2)

Description

[Timea Cernea [:tbabos][inactive]]

Affected versions

• Nightly 70.0a1 (2019-08-29)
• Beta 69.0 (64-bit)
• Release 68.0.2 (64-bit)

Affected platforms
Windows 7/10
Ubuntu 18.04
MacOS 10.14

Preconditions

• "browser.search.region" set to "US".

Steps to reproduce

• Launch Firefox
• Check if you have ebay as default search engine option in the "One-click search engines" list on the about:preferences#search page
• If Yes, restart the browser

Expected result

• Ebay default search engine is available in the "One-click search engines" list after restart

Actual Result

• Ebay search engine is not listed in the "One-click search engines" list anymore

Regression-Range
Will try to search for it asap, latest Nightly, Beta and Release are affected.

Comment 1

[Mark Banner (:standard8)]

Are you looking at the one click engines in the search bar or the address bar?

In the search bar, I believe this is expected as the default engine is listed at the top above the suggestions.

In the address bar, it should be listed.

Comment 2

[Timea Cernea [:tbabos][inactive]]

Attachment: Screenshot of issue

I was looking at the list from about:preferences#search. Edited the bug so it is more clear now

Comment 3

[Mark Banner (:standard8)]

I currently can't reproduce this at the moment. I've used both en-US and en-GB locales of Firefox, with the region set to US, using a newly created profile and setting the region before first start.

Comment 4

[Timea Cernea [:tbabos][inactive]]

Can you please try to set up the region after launching for the first time and then restart?

Comment 5

[Mark Banner (:standard8)]

That still works fine for me, though I'm going from a GB region to the US one.

What region are you coming from, then going to? Also, did you check that it still stayed as US after the restart?

Comment 6

[Timea Cernea [:tbabos][inactive]]

Attachment: Video of the issue

Starting from Romania region and changing to US. Forgot to show it at the end of the video, but I check the region afterward and it was US.

Comment 7

[Mark Banner (:standard8)]

Thanks for the extra information. Starting with the RO is the key.

The issue appears to be that the default config (list.json) for en-US is to include eBay for most reason. The remote server setup (absearch) says that eBay shouldn't be included for the en-US / RO region.

So Firefox starts up, includes eBay, then gets the region, at which point it then would remove eBay. You see this on the restart if you don't change the region.

However, when we change back from RO to US region, then we're not re-adding eBay for some reason.

I think we'll probably be improving this with search modernisation, but I'll discuss with Dale tomorrow.

Comment 8

[Alin Ilea, Desktop Test Engineering]

Hi,

The issue is still reproducible in latest Nightly build 74.0a1 (2020-01-14).

Comment 9

[Mark Banner (:standard8)]

Thanks, I don't think we need to track this per version. It has been this way for a long time. We'll might be fixing it with search-modernization, but we'll review once we get that landed.

Comment 10

[Mark Banner (:standard8)]

Timea, I think this is now fixed with the switch to modernisation that happened in FF 79. Please can you confirm?

Comment 11

[Timea Cernea [:tbabos][inactive]]

Seems to be fixed, I can no longer reproduce it on the latest Firefox Release 79 on Windows 10 and MacOS 10.13.

Comment 12

[Mark Banner (:standard8)]

Great, thank you for checking, I think all the architecture changes we did fixed this.

Comment 13

[geo. anderson]

68.12.0esr apparently updated yesterday or today 8/31/20, ebay has disappeared from my list of search engine choices both on the main screen and on the "change search settings" screen. Ack!

Comment 14

[Mark Banner (:standard8)]

(In reply to geo. anderson from comment #13)

68.12.0esr apparently updated yesterday or today 8/31/20, ebay has disappeared from my list of search engine choices both on the main screen and on the "change search settings" screen. Ack!

Hi, Firefox 68esr is now almost end of life - 78esr is already available, and will be rolled out to 68esr users on or soon after the 22nd September which I believe is the EOL date.

As a result, we're not doing any more changes in 68esr unless there's a security issue or something severe before that date.

We've made lots of improvements between 68esr and 78esr that will provide a more consistent set of search engines. Also, please note that eBay is only available in particular region/locale combinations.

If this is still an issue after updating to 78esr or the main release, please feel free to file a new bug and include more details.

Also, please don't comment on closed bugs - comments tend to frequently get lost or missed on closed bugs.

Comment 15

[geo. anderson]

Mark, I don't have the slightest idea what you are saying about the missing eBay search engine, except that you're not going to fix it.

FF is a tool for me, not a hobby. I escaped from the bleeding edge by going to the ESRs and I run whatever comes my way via the update notifications. I am totally uninterested in the internals and the politics despite the fact that I am a EE/computer architect by trade. I am similarly uninterested in the internals of my microwave oven.

With the disaster just dumped on my plate with the Android rewrite, and now this annoyance, my decades-long loyalty to FF aka Phoenix is being severely tested.

Better is the enemy of good.

Comment 16

[Mark Banner (:standard8)]

(In reply to geo. anderson from comment #15)

Mark, I don't have the slightest idea what you are saying about the missing eBay search engine, except that you're not going to fix it.

I'm saying we have likely fixed it in the next major version that you'll update to which will happen around the end of September.

The only thing I can suggest at the moment is to refresh Firefox and see if that helps. If it doesn't please open a fresh bug, so that we're not commenting on a closed bug that is potentially nothing to do with your actual issue.