1577734 - Crash in [@ mozilla::dom::HTMLMediaElement::MediaStreamRenderer::UpdateGraphTime]

Status: RESOLVED FIXED

(Core :: Audio/Video: MediaStreamGraph, defect, P2)

Description

[Calixte Denizet (:calixte)]

This bug is for crash report bp-30db63b6-96d4-46ce-a610-da3870190830.

Top 10 frames of crashing thread:

0 xul.dll void mozilla::dom::HTMLMediaElement::MediaStreamRenderer::UpdateGraphTime dom/html/HTMLMediaElement.cpp:443
1 xul.dll nsresult mozilla::detail::RunnableFunction<`lambda at z:/task_1567112520/build/src/obj-firefox/dist/include/mozilla/StateWatching.h:248:34'>::Run xpcom/threads/nsThreadUtils.h:564
2 xul.dll void mozilla::AutoTaskDispatcher::DrainDirectTasks xpcom/threads/TaskDispatcher.h:99
3 xul.dll void mozilla::EventTargetWrapper::FireTailDispatcher xpcom/threads/AbstractThread.cpp:71
4 xul.dll nsresult mozilla::detail::RunnableMethodImpl< xpcom/threads/nsThreadUtils.h:1176
5 xul.dll mozilla::CycleCollectedJSContext::ProcessStableStateQueue xpcom/base/CycleCollectedJSContext.cpp:435
6 xul.dll mozilla::CycleCollectedJSContext::AfterProcessTask xpcom/base/CycleCollectedJSContext.cpp:494
7 xul.dll nsThread::ProcessNextEvent xpcom/threads/nsThread.cpp:1283
8 xul.dll NS_ProcessNextEvent xpcom/threads/nsThreadUtils.cpp:486
9 xul.dll mozilla::ipc::MessagePump::Run ipc/glue/MessagePump.cpp:88

There are 16 crashes (from 5 installations) in nightly 70 with buildid 20190829214656. In analyzing the backtrace, the regression may have been introduced by patch [1] to fix bug 1573102.

[1] https://hg.mozilla.org/mozilla-central/rev?node=f61dd73cac3a

Comment 1

[Andreas Pehrson [:pehrsons]]

So we were wrong here, because Unwatch unwatches, but any notifications that were already scheduled will still run (async!).

Comment 2

[Andreas Pehrson [:pehrsons]]

I think I will remove the unsetting of mGraphTimeOffset, so we match pre-bug1573102 behavior.

Comment 3

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1577734 - Don't unset mGraphTimeOffset in MediaStreamRenderer. r?karlt

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/111049359225
Don't unset mGraphTimeOffset in MediaStreamRenderer. r=padenot

Comment 5

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/111049359225

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/releases/mozilla-beta/rev/111049359225