1577742 - Tab overflow indicators overlap the megabar when it's open

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Dão Gottwald [:dao]]

We need to trump this z-index: https://searchfox.org/mozilla-central/rev/7088fc958db5935eba24b413b1f16d6ab7bd13ea/browser/themes/shared/tabs.inc.css#450

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1577742 - Inrease the megabar's z-index so it overlaps the tab overflow indicators. r=harry

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/21483daf4d9d
Inrease the megabar's z-index so it overlaps the tab overflow indicators. r=harry

Comment 3

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/21483daf4d9d

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/releases/mozilla-beta/rev/21483daf4d9d

Comment 5

[Timea Zsoldos [:tzsoldos], Desktop QA]

I have reproduced this issue using Firefox 70.0a1 (2019.08.18) on Win 8.1 x64 (see attached file: reproduced.png).
I can confirm this issue is fixed on latest nightly from 2019.10.21 (attached file: verified-nightly.png) on Win 8.1 x64. On Firefox 70.0 and 70.0b7 still reproducible.
Maybe I am wrong. In this case can you provide me some steps to reproduce this issue correctly or attached some screenshots. Thanks!

Comment 6

[Dão Gottwald [:dao]]

There's no file attached.

Comment 7

[Timea Zsoldos [:tzsoldos], Desktop QA]

Attachment: files.zip

Sorry, here is the attached file.

Comment 8

[Dão Gottwald [:dao]]

You need to open the megabar to reproduce the bug. Note that the megabar is disabled on beta.

Comment 9

[Timea Zsoldos [:tzsoldos], Desktop QA]

Attachment: nightly+beta.7z

Setting the browser.urlbar.megabar pref to true, then minimize and maximize the browser. I verified using Firefox 72.0a1 and 70.0b13 on Win 8.1 x64, macOS 10.15 and Ubuntu 18.04 x64.
Based on the second attachment (nightly+beta.zip) can I consider the issue as verified? Thanks!

Comment 10

[Dão Gottwald [:dao]]

(In reply to Timea Zsoldos [:zstimi/tzsoldos], Desktop Release QA from comment #9)

Created attachment 9103938 [details]
nightly+beta.7z

Setting the browser.urlbar.megabar pref to true, then minimize and maximize the browser. I verified using Firefox 72.0a1 and 70.0b13 on Win 8.1 x64, macOS 10.15 and Ubuntu 18.04 x64.
Based on the second attachment (nightly+beta.zip) can I consider the issue as verified? Thanks!

Yep, thanks.