Closed Bug 1577859 Opened 2 months ago Closed Last month

Remove support for container scrolling

Categories

(Core :: Panning and Zooming, task, P3)

task

Tracking

()

RESOLVED FIXED
mozilla71
Tracking Status
firefox70 --- wontfix
firefox71 --- fixed

People

(Reporter: botond, Assigned: botond)

References

Details

Attachments

(4 files)

Containerless scrolling has been shipping on Android since 67 (bug 1137890), and on desktop since long before that.

It's been pretty stable and we haven't seen any regressions from it in the past couple of release cycles.

I think this is a good time to remove the container scrolling code. This will make scrolling-related code easier to understand.

Assignee: nobody → botond

There will be additional cleanup to remove codepaths that were only used with container scrolling but where the dependency is less obvious, but I'm posting what I have for now.

Attachment #9091453 - Attachment description: Bug 1577859 - Remove the layout.scroll.root-frame-containers pref and code that depends directly on it. r=mstange → Bug 1577859 - Remove the layout.scroll.root-frame-containers pref and code that depends directly on it. r=tnikkel
Attachment #9092216 - Attachment description: Bug 1577859 - Additional post container scrolling removal cleanup in Layout code. r=tnikkel → Bug 1577859 - Additional post container scrolling removal cleanup in Layout code. r=tnikkel

With containerless scrolling, scrollbar layers and their target scrolled layers
will be in sibling subtrees.

Depends on D45596

Pushed by bballo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/286cbc3b542b
Remove the layout.scroll.root-frame-containers pref and code that depends directly on it. r=tnikkel

I'm going to start landing this piece by piece.

Keywords: leave-open
Pushed by bballo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0ece55dd7147
Additional post container scrolling removal cleanup in Layout code. r=tnikkel
Pushed by bballo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e291531d8dbe
Stop handling scrollbar layers that are descendants of the scrolled content. r=tnikkel
https://hg.mozilla.org/integration/autoland/rev/c0797e496fd9
Additional post container scrolling removal cleanup in APZ code. r=tnikkel
Keywords: leave-open
Status: NEW → RESOLVED
Closed: Last month
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
Regressions: 1584691
You need to log in before you can comment on or make changes to this bug.