1577877 - Set Directory Root should work for threads

Status: RESOLVED WORKSFORME

(DevTools :: Debugger, defect, P3)

Description

[Jason Laster [:jlast]]

STR:
Open Browser Toolbox
Right click on e.g. Main Process and pick Set Directory Root from the context menu
The panel says This page has no sources and the breadcrumbs bar at the top is broken

Comment 1

[Chujun Lu]

https://bugzilla.mozilla.org/show_bug.cgi?id=1588803 is a duplication of this one.

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: source tree with mixed results

(In reply to Jason Laster [:jlast] from comment #0)

STR:
Open Browser Toolbox
Right click on e.g. Main Process and pick Set Directory Root from the context menu
The panel says This page has no sources and the breadcrumbs bar at the top is broken

Bug 1588803 most likely got rid of this exception, but the end result looks clunky in the OBT.
It might be related to bug 1594205.

Comment 3

[Chujun Lu]

Attachment: sameFileName.mp4

I noticed a similar behavior while working on Bug 1588803 : when set a directory to root, other directories with the same name but in different threads will be displayed. This behavior was implemented in https://phabricator.services.mozilla.com/D32379 for workers. I think it's the reason for multiple content in the screenshot in the above comment.

(Page in the video: http://dbg-workers.glitch.me/)

Comment 4

[Chujun Lu]

I was wondering do we wanna keep this, or only show the directory of the targeted thread?

Comment 5

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Attachment: image.png

(In reply to Alexandre Poirot [:ochameau] from comment #2)

Bug 1588803 most likely got rid of this exception, but the end result looks clunky in the OBT.
It might be related to bug 1594205.

Note that I tested this on the latest m-c and I am still seeing This page has no sources. message.
See the attached screenshot.
Honza

Comment 6

[Chujun Lu]

Attachment: Screen Shot 2019-11-11 at 11.47.18 PM.png

Hi Honza, would you mind letting me know your STR? Thanks!

I tried 1.Open chrome://browser/content/browser.xhtml 2.Open a new tab, open about:debugging 3. Click "This Nightly" 4.Click Inspect on the Nightly tab 5.Set Main thread as directory root.

Wasn't able to reproduce what you saw.

Comment 7

[Jan Honza Odvarko [:Honza] (always need-info? me)]

I can't reproduce this on my machine anymore.

I am closing the report to clean up, but if anybody is able to reproduce this, please reopen.

Honza