Closed Bug 1577917 Opened 5 years ago Closed 5 years ago

Add missing tooltip to dismiss

Categories

(Firefox :: New Tab Page, enhancement, P1)

Product:
Firefox
Component:
New Tab Page
Type:
enhancement

Tracking

()

Status:
RESOLVED DUPLICATE of bug 1577655
Iteration:
71.2 - Sept 16 - 29

People

(Reporter: gsuntop, Assigned: gsuntop)

References

Details

Notice dismiss button is missing tooltip, we can add title="Dismiss" as part of this patch which can be later picked from ftl file when we localize DSDismiss. This will help resolve accessibility issue around missing label on dismiss button.

https://github.com/mozilla/activity-stream/blob/master/content-src/components/DiscoveryStreamComponents/DSDismiss/DSDismiss.jsx#L67

Iteration: --- → 71.1 - Sept 2 - 15
Priority: -- → P1
Iteration: 71.1 - Sept 2 - 15 → 71.2 - Sept 16 - 29

Using aria-label instead and landed in https://github.com/mozilla/activity-stream/commit/1b44d527ecee506e38eb6bd76e24ec97ce5a8eee

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.