1578055 - [XdndDirectSave] nsDragService still uses "host" from nsSystemInfo

Status: RESOLVED WONTFIX

(Core :: Widget: Gtk, defect, P5)

Description

[Jan Beich]

host property was removed in bug 1361601 on 2017-05-03 but nsDragService started to use it after bug 396370 (from v1) on 2018-10-04. Maybe drop or convert to PR_SI_HOSTNAME.

https://searchfox.org/mozilla-central/rev/e8f334670ddf/widget/gtk/nsDragService.cpp#1462

Comment 1

[Martin Stránský [:stransky] (ni? me)]

This affects XdndDirectSave which is no longer used (at least I can't find any application which uses it).
Let's close it and reopen if we hit any real-life scenario.

Comment 2

[Tom S [:evilpie]]

This affects XdndDirectSave which is no longer used (at least I can't find any application which uses it).

Have you tested Nemo? Drag and drop of images still works for me with version 5.0.5.

Comment 3

[Martin Stránský [:stransky] (ni? me)]

Yes, I tested Nemo, seems to use text/x-moz-url.

Comment 4

[Tom S [:evilpie]]

I just tested disabling the XdndDirectSave0 code in nsDragService and afterwards dragging an image to the Desktop produces a link instead of an image file. So it's working.

See also:
https://github.com/linuxmint/nemo/blob/7fe83632eca5801a55992dc08c52767b6d8685cb/libnemo-private/nemo-tree-view-drag-dest.c#L90

Comment 5

[Martin Stránský [:stransky] (ni? me)]

Okay, Thanks.