Closed
Bug 1578147
Opened 5 years ago
Closed 5 years ago
align the Rust and C++ representations of WritingMode
Categories
(Core :: CSS Parsing and Computation, enhancement, P3)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla71
| Tracking | Status | |
|---|---|---|
| firefox71 | --- | fixed |
People
(Reporter: heycam, Assigned: heycam)
Details
Attachments
(1 file)
No description provided.
| Comment hidden (obsolete) |
|
Assignee | |
Comment 2•5 years ago
|
||
|
|
Assignee | |
Comment 3•5 years ago
|
||
Still a bit orange...
|
|
Assignee | |
Comment 4•5 years ago
|
||
|
|
Assignee | |
Comment 5•5 years ago
|
||
|
|
Assignee | |
Comment 6•5 years ago
|
||
I guess I could remove the ServoWritingMode definition and just replace its use in ServoComputedData with mozilla::WritingMode. Let me know if you think I should.
|
|
Assignee | |
Comment 7•5 years ago
|
||
(Or make Rust WritingMode get cbindgened, and move all the current mozilla::WritingMode methods down onto the cbindgened version.)
|
|
Assignee | |
Comment 8•5 years ago
|
||
Pushed by cmccormack@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/623d63b7f9e0 Align the Rust and C++ representations of WritingMode. r=emilio,jfkthame
|
||
Comment 10•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox71:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in
before you can comment on or make changes to this bug.
Description
•