1578194 - Having node_modules installed in a sub-directory can cause failures in ESLint

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, task, P1)

Description

[Mark Banner (:standard8)]

STR

$ cd tools/lint/eslint/eslint-plugin-mozilla
$ npm install
$ cd ../../../../
$ ./mach eslint tools

Expected Results

• No errors

Actual Results

An error occurred running eslint. Please check the following error messages:


Oops! Something went wrong! :(

ESLint: 6.2.2.

ESLint couldn't find the config "@ljharb" to extend from. Please check that the name of the config is correct.

The config "@ljharb" was referenced from the config file in "/Users/mark/dev/gecko/tools/lint/eslint/eslint-plugin-mozilla/node_modules/define-properties/.eslintrc".

I think this is due to the Eslint 6 upgrade. The config files now have stricter matching to .eslintignore and our node_modules exclusion is **/node_modules/**/*.* which doesn't catch dot files.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1578194 - ESLint's ignore should properly ignore dot files in node_modules as well. r?ahal,Mossop

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6a6153cb19e9
ESLint's ignore should properly ignore dot files in node_modules as well. r=mossop

Comment 3

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/6a6153cb19e9