Closed Bug 1578361 Opened 11 months ago Closed 11 months ago

Remove unused localTransport getter on debugger-client

Categories

(DevTools :: General, task, P3)

task

Tracking

(firefox71 fixed)

RESOLVED FIXED
Firefox 71
Tracking Status
firefox71 --- fixed

People

(Reporter: jdescottes, Assigned: jdescottes)

Details

Attachments

(1 file)

In debugger-client's constructor we set

this.localTransport = this._transport.onOutputStreamReady === undefined;

https://searchfox.org/mozilla-central/rev/e04021f29e6d8a37753ba2b510432315ce05a8d7/devtools/shared/client/debugger-client.js#61

While this works, it's very weird to rely on a random callback being defined or not on the transport to know if we are on using a localtransport.

This is not used so it should be removed.

This was initially added in Bug 907755 for old telemetry probes.

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Component: General → Debugger
Component: Debugger → General
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/872fcf1f5fa6
removed unused localTransport getter on debugger-client r=ladybenko
Status: NEW → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71
Assignee: nobody → jdescottes
You need to log in before you can comment on or make changes to this bug.