Closed
Bug 1578361
Opened 6 years ago
Closed 6 years ago
Remove unused localTransport getter on debugger-client
Categories
(DevTools :: General, task, P3)
DevTools
General
Tracking
(firefox71 fixed)
RESOLVED
FIXED
Firefox 71
| Tracking | Status | |
|---|---|---|
| firefox71 | --- | fixed |
People
(Reporter: jdescottes, Assigned: jdescottes)
Details
Attachments
(1 file)
In debugger-client's constructor we set
this.localTransport = this._transport.onOutputStreamReady === undefined;
While this works, it's very weird to rely on a random callback being defined or not on the transport to know if we are on using a localtransport.
This is not used so it should be removed.
| Assignee | ||
Comment 1•6 years ago
|
||
This was initially added in Bug 907755 for old telemetry probes.
Comment 2•6 years ago
|
||
Bugbug thinks this bug should belong to this component, but please revert this change in case of error.
Component: General → Debugger
| Assignee | ||
Updated•6 years ago
|
Component: Debugger → General
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/872fcf1f5fa6
removed unused localTransport getter on debugger-client r=ladybenko
Comment 4•6 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox71:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71
Updated•6 years ago
|
Assignee: nobody → jdescottes
You need to log in
before you can comment on or make changes to this bug.
Description
•