1578435 - Update UrlbarView's selection model to support selection within "tip" results

Status: RESOLVED FIXED

(Firefox :: Address Bar, task, P2)

Description

[Harry Twyford]

The user needs to be able to navigate to both the main button and and help link. UrlbarView.selectBy is one major method that will need updating.

Comment 1

[Harry Twyford]

Verdi, should the intervention button and help icon have different states for hover vs. selected? Right now we highlight autocomplete rows grey if they're hovered and blue if they're selected. Currently the UX spec for Interventions only specifies the state for selected.

Comment 2

[Harry Twyford]

Attachment: Bug 1578435 - Update UrlbarView's selection model to support selection within "tip" results. r?adw

Comment 3

[Verdi [:verdi] Best to slack me]

(In reply to Harry Twyford [:harry] from comment #1)

Verdi, should the intervention button and help icon have different states for hover vs. selected? Right now we highlight autocomplete rows grey if they're hovered and blue if they're selected. Currently the UX spec for Interventions only specifies the state for selected.

The row itself shouldn't have a hover state. The button should use the "Primary" button hover state and the help icon should use the "Ghost" button hove state.

Comment 4

[Harry Twyford]

Afaik, we previously discussed the buttons taking on the primary hover state when they were selected with the keyboard. Should they have a different appearance when selected with the keyboard?

Comment 5

[Verdi [:verdi] Best to slack me]

Attachment: Hybrid button.png

(In reply to Harry Twyford [:harry] from comment #4)

Afaik, we previously discussed the buttons taking on the primary hover state when they were selected with the keyboard. Should they have a different appearance when selected with the keyboard?

Sorry I wasn't more clear. I updated Invision and attached a mock of how this button should work.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e4bef719042a
Update UrlbarView's selection model to support selection within "tip" results. r=adw

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/e4bef719042a