Closed Bug 1578435 Opened Last month Closed Last month

Update UrlbarView's selection model to support selection within "tip" results

Categories

(Firefox :: Address Bar, task, P2)

task
Points:
5

Tracking

()

RESOLVED FIXED
Firefox 71
Iteration:
71.1 - Sept 2 - 15
Tracking Status
firefox71 --- fixed

People

(Reporter: harry, Assigned: harry)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

The user needs to be able to navigate to both the main button and and help link. UrlbarView.selectBy is one major method that will need updating.

Verdi, should the intervention button and help icon have different states for hover vs. selected? Right now we highlight autocomplete rows grey if they're hovered and blue if they're selected. Currently the UX spec for Interventions only specifies the state for selected.

Assignee: nobody → htwyford
Status: NEW → ASSIGNED
Iteration: --- → 71.1 - Sept 2 - 15
Flags: needinfo?(mverdi)
See Also: → 1578436, 1578438

(In reply to Harry Twyford [:harry] from comment #1)

Verdi, should the intervention button and help icon have different states for hover vs. selected? Right now we highlight autocomplete rows grey if they're hovered and blue if they're selected. Currently the UX spec for Interventions only specifies the state for selected.

The row itself shouldn't have a hover state. The button should use the "Primary" button hover state and the help icon should use the "Ghost" button hove state.

Flags: needinfo?(mverdi)

Afaik, we previously discussed the buttons taking on the primary hover state when they were selected with the keyboard. Should they have a different appearance when selected with the keyboard?

Flags: needinfo?(mverdi)
Blocks: 1580808
Priority: -- → P2
Attached image Hybrid button.png

(In reply to Harry Twyford [:harry] from comment #4)

Afaik, we previously discussed the buttons taking on the primary hover state when they were selected with the keyboard. Should they have a different appearance when selected with the keyboard?

Sorry I wasn't more clear. I updated Invision and attached a mock of how this button should work.

Flags: needinfo?(mverdi)
Pushed by htwyford@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e4bef719042a
Update UrlbarView's selection model to support selection within "tip" results. r=adw
Status: ASSIGNED → RESOLVED
Closed: Last month
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71
Depends on: 1582022
You need to log in before you can comment on or make changes to this bug.