157851 - Function AddAttrToElem() not needed...

Status: RESOLVED FIXED

(SeaMonkey :: Composer, defect)

Description

[Johnny Stenback (:jst)]

The function AddAttrToElem() in editor.js is making a simple and fast thing
complicated and slow, it currently does:

function AddAttrToElem(dom, attr_name, attr_value, elem)
{
  var a = dom.createAttribute(attr_name);
  if ( a )
  {
    a.value = attr_value;
    elem.setAttributeNode(a);
  }
}

when it could simply do:

function AddAttrToElem(dom, attr_name, attr_value, elem)
{
  elem.setAttribute(attr_name, attr_value);
}

or better yet, remove the method all together and make the callers call
elem.setAtribute() directly.

Comment 1

[Kathleen :Brade]

-->brade

Comment 2

[Kathleen :Brade]

Attachment: patch

Comment 3

[Johnny Stenback (:jst)]

Comment on attachment 91702 [details] [diff] [review]
patch

sr=jst

Comment 4

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 91702 [details] [diff] [review]
patch

r=sicking

thanks!!

Comment 5

[Kathleen :Brade]

fix checked in for respin