1578523 - Delete LDAP server broken

Status: RESOLVED FIXED

(MailNews Core :: LDAP Integration, defect, P1)

Description

[Jorg K (CEST = GMT+2)]

+++ This bug was initially created as a clone of Bug #1576365 +++

In options, composition, addressing you bring up the list of LDAP servers and click delete.

From bug 1576365 comment #36:

Delete doesn't work at all, you get:
NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIAbManager.deleteAddressBook] 2 abCommon.js:372
AbDeleteDirectory chrome://messenger/content/addressbook/abCommon.js:372
removeDirectory chrome://messenger/content/addressbook/pref-editdirectories.js:148
oncommand chrome://messenger/content/addressbook/pref-editdirectories.xul:1

Alice found this range:
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=8bbeb44f15b366817cab0573ce3807d4fc09fc33&tochange=fa465d49d7bf9f021772b7080340e9856edf71c5

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: 1578523-ldap-delete-1.diff

LDAP directories have two URIs… and I've used the wrong one.

I can't believe we have no test that fails because of this.

Comment 2

[Geoff Lankow (:darktrojan)]

Comment on attachment 9090247 [details] [diff] [review]
1578523-ldap-delete-1.diff

Oh yeah, we went to beta the other day.

Comment 3

[Magnus Melin [:mkmelin]]

Comment on attachment 9090247 [details] [diff] [review]
1578523-ldap-delete-1.diff

Review of attachment 9090247 [details] [diff] [review]:
-----------------------------------------------------------------

Thx! r=mkmelin

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/109de898dc04
Fix deletion of LDAP address book. r=mkmelin

Comment 5

[Jorg K (CEST = GMT+2)]

TB 70 beta 1:
https://hg.mozilla.org/releases/comm-beta/rev/ad3c158cf10f618bfc0eec26dcddccbacf39f39c