1578565 - Inactive CSS: False positive with SVG.

Status: VERIFIED FIXED

(DevTools :: Inspector: Rules, defect, P1)

Description

[Emilio Cobos Álvarez (:emilio)]

STR:

• Open data:text/html,<svg width=100 height=100><rect y="0.41" width="60" fill="grey" style="height: 80px"></rect></svg>
• Inspect the <rect> element.

ER:

• No inactive CSS warning, as height clearly applies.

AR:

• It says height doesn't apply, but it does.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1578565 - SVG and MathML elements don't follow the CSS layout model.

We could be more explicit and also handle svg on the height / width stuff
(width and height don't apply to all SVG elements).

But this avoids the false positive for now.

Comment 2

[Patrick Brosset <:pbro>]

We might want to attempt uplifting this to 70. It's very early in the beta cycle, and this fix looks very safe to me. Because this is a "false positive" problem, which we consider very important for this feature, and because the feature is riding the trains with 70, I think it's important to do this.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1ed874403355
SVG and MathML elements don't follow the CSS layout model. r=pbro

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9090305 [details]
Bug 1578565 - SVG and MathML elements don't follow the CSS layout model.

Beta/Release Uplift Approval Request

• User impact if declined: False positive warning.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Very simple fix to avoid treating SVG elements as non-replaced inline boxes.
• String changes made/needed: none

Comment 5

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/1ed874403355

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9090305 [details]
Bug 1578565 - SVG and MathML elements don't follow the CSS layout model.

Fix for a feature shipping in 70, doesn't look risky, seems reasonable to uplift for beta 4.

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/bdc4c105ecc7

Comment 8

[Rares Doghi, Desktop QA]

Hi, This issue is Verified as fixed on Mac OsX 10.14, Windows 10 and Ubuntu 18.04 in both Nightly 71.0a1 (2019-09-04) as well as Beta 70.0b4.