1578567 - Come up with an alternative solution to adding the preview highlight to a token.

Status: UNCONFIRMED

(DevTools :: Debugger, task, P3)

Description

[janelledement]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/76.0.3809.132 Safari/537.36

Steps to reproduce:

When a token is broken up by a search result and the user hovers over any of those pieces, the preview highlight is added to all the elements involved. Do do this, we are relying on a while loop to search for related elements (to make sure they all get highlighted). These loops are rather complicated and could possibly be tricked.

The new solution should:

• Not rely on looping through elements
• Not rely on using nodeType
• Not use methods like includes which can be tricked.

Here is a short screencast about this bug: https://www.loom.com/share/72d9dc7708a4457593215dbc36e41dee

Comment 1

[janelledement]

The screencast in the description was deleted by accident. Here is a screencast about this bug: https://www.loom.com/share/67a02691d67a40d38cb5f330c06a287a

Comment 2

[janelledement]

Attachment: Bug 1578567 - Fix token highlighting when broken by search terms r=davidwalsh

Alternative solution for adding preview highlight

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months.
:bomsy, could you have a look please?
For more information, please visit auto_nag documentation.