Closed Bug 1578583 Opened Last month Closed 27 days ago

Add support for a resultSpan property on results

Categories

(Firefox :: Address Bar, enhancement, P2)

enhancement
Points:
3

Tracking

()

RESOLVED FIXED
Firefox 71
Iteration:
71.2 - Sept 16 - 29
Tracking Status
firefox71 --- fixed

People

(Reporter: harry, Assigned: harry)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

This property allows Urlbar results to span multiple rows in the autocomplete dropdown. It is needed so that Interventions can span three rows. We'd need something like UrlbarUtils.getResultSpanForType(result.type) to return resultSpan for a given type. We could implement this by setting a min-height on result rows and use resultSpan as a multiplier, or we could possibly make the results a flexbox and set the rows' flex-grow equal to resultSpan.

See Also: → 1579922
Assignee: nobody → htwyford
Iteration: --- → 71.2 - Sept 16 - 29
Status: NEW → ASSIGNED
Priority: -- → P2
Pushed by htwyford@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/96fecf5a0833
Add support for a resultSpan property on results. r=adw
Status: ASSIGNED → RESOLVED
Closed: 27 days ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71
Regressions: 1582329
You need to log in before you can comment on or make changes to this bug.