1578700 - Change the use counter setup to merge use counters for the page at once

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task)

Description

[Emilio Cobos Álvarez (:emilio)]

Rather than doing parent-document lookup every time you call SetDocumentAndPageUseCounters.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1578700 - Rename a variable to better follow our coding style.

It's a constant, not a global. This matches both the Mozilla and Google coding
styles so should hopefully be uncontroversial.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1578700 - Simplify SetDocumentUseCounter.

It's just a bit flag, should be no need of checking whether the bit is set
before.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1578700 - Change use counter setup to propagate the page use counters together.

This is so that SetUseCounter is as cheap as possible.

This is in preparation for hooking the CSS use counters to telemetry. We want
CSS use counters to be fast and be propagated at once to the parent page. This
will make sure to use the same setup as everywhere else.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a52f74c30955
Rename a variable to better follow our coding style. r=smaug
https://hg.mozilla.org/integration/autoland/rev/fc006441b6d9
Simplify SetDocumentUseCounter. r=smaug
https://hg.mozilla.org/integration/autoland/rev/adfc50ea76f4
Change use counter setup to propagate the page use counters together. r=smaug

Comment 5

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/a52f74c30955
https://hg.mozilla.org/mozilla-central/rev/fc006441b6d9
https://hg.mozilla.org/mozilla-central/rev/adfc50ea76f4

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9090352 [details]
Bug 1578700 - Change use counter setup to propagate the page use counters together.

Beta/Release Uplift Approval Request

• User impact if declined: See bug 1578661 comment 51.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Medium
• Why is the change risky/not risky? (and alternatives if risky): While this is a change to the setup of how we recollect data, our tests do cover various edge cases here, and so far the data in Nightly 71 vs Nightly 70 looks pretty comparable.

So it doesn't seem this patch introduced any logic error that changed what we measure.

• String changes made/needed: none

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9090350 [details]
Bug 1578700 - Rename a variable to better follow our coding style.

Fix for use counters needed for some other approved patches. Approved for 70.0b10.

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/84589f69c57b
https://hg.mozilla.org/releases/mozilla-beta/rev/cbb2a9654a65
https://hg.mozilla.org/releases/mozilla-beta/rev/2d698478059c