1578716 - Make browser_ext_contextMenus_targetUrlPatterns.js wait for end of load of about:reader before sending mouse event

Status: RESOLVED FIXED

(WebExtensions :: Frontend, defect, P2)

Description

[Peter Van der Beken [:peterv]]

We're running into a test failure in browser/components/extensions/test/browser/browser_ext_contextMenus_targetUrlPatterns.js with session history running in the parent.
The privileged_are_allowed_to_use_restrictedSchemes test switches a document to reader mode, and then sends a mouse event to open a context menu. However, it doesn't wait till we've actually loaded the about:reader document (it uses an onUpdated listener but doesn't check that changeInfo.status is 'complete', so the code in the listener runs when changeInfo.status is 'loading'). Sending the mouse event fails, depending on timing issues, if layout for the about:reader document hasn't happened yet.

Comment 1

[Peter Van der Beken [:peterv]]

Attachment: Bug 1578716 - Make browser_ext_contextMenus_targetUrlPatterns.js wait for end of load of about:reader before sending mouse event. r?kmag!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0b809df52f3f
Make browser_ext_contextMenus_targetUrlPatterns.js wait for end of load of about:reader before sending mouse event. r=kmag

Comment 3

[Dorel Luca [:dluca]]

Backed out changeset 0b809df52f3f (bug 1578716) for Eslint failure. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=265132742&repo=autoland&lineNumber=288

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&revision=0b809df52f3f017f970fcf724c4de871e105deaa

Backout:
https://hg.mozilla.org/integration/autoland/rev/3d7b9bf00bdbf2b787d9e3bd6c28ee087a4e871e

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bb2edf57e24c
Make browser_ext_contextMenus_targetUrlPatterns.js wait for end of load of about:reader before sending mouse event. r=kmag

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/bb2edf57e24c

Comment 6

[Alex Cornestean]

Hello,

Will this fix require manual validation? If yes, please provide some steps to reproduce in order to correctly test it and also, please set the "qe-verify+" flag. Otherwise, could the "qe-verify-" flag be added? Thanks!

Comment 7

[Luca Greco [:rpl] [:luca] [:lgreco]]

Setting qe-verify-, this is a test-only change.