1578831 - Privacy Panel: Send report string on OFF state

Status: RESOLVED FIXED

(Firefox :: Protections UI, task, P3)

Description

[Betsy Mikel [:betsymi]]

Problem: If user turns off ETP, it's not helpful if they report the site is still broken. This would mean ETP was not the cause of the breakage and a report will not be useful. Firefox would like to know about sites in which turning off ETP led to fixing breakage.

Resolution: Ask users to report if turning off ETP fixed breakage.

Attached is comp for prompting users to send report upon fixage. Please note, the string is outdated on the comp and it is for visual reference only.

• String: Is this website working properly now? Send report
• Appears in OFF state only
• Link Send Report directly to Report a Broken Site subpanel

Comment 1

[Betsy Mikel [:betsymi]]

Attachment: ETP OFF, Send Report Comp.png

Comment 2

[Betsy Mikel [:betsymi]]

Attachment: Send Report.png

Comment 3

[(inactive) Nihanth Subramanya [:nhnt11]]

I'm going to work on this shortly and had one important question:

Is this replacing the "Site Not Working?" link when ETP is ON? Or is it an additional link when ETP is OFF? And if it's an addition, should we remove the Send Report link from the "Site Not Working?" subview?

It's a bit urgent to spec this out properly because it's a string change/addition and uplift should happen ASAP. :flod, could you help me figure out if this is a reasonable string addition to uplift? I can't remember the last time I uplifted strings (maybe for a cert error string at some point).

Comment 4

[(inactive) Nihanth Subramanya [:nhnt11]]

Forgot to needinfo? flod in comment 3.

Comment 5

[Eric Pang [:epang] UX]

(In reply to Nihanth Subramanya [:nhnt11] from comment #3)

I'm going to work on this shortly and had one important question:
Is this replacing the "Site Not Working?" link when ETP is ON?

No, the link and string stays as in when ETP is on

Or is it an additional link when ETP is OFF? And if it's an addition, should we remove the Send Report link from the "Site Not Working?" subview?

No need, the link should go directly to the 'Report a Broken Site' panel and bypass the panel with the 'Send Report' link

Comment 6

[Francesco Lodolo [:flod]]

It's a bit urgent to spec this out properly because it's a string change/addition and uplift should happen ASAP. :flod, could you help me figure out if this is a reasonable string addition to uplift? I can't remember the last time I uplifted strings (maybe for a cert error string at some point).

Given that we don't have a patch yet, I would expect to need a few more days before strings are actually available for localization.

That's a risk that product needs to evaluate: how important is this feature in 70? It's important enough to accept that some languages might end up with partially localized panels? Note that some will do anyway, given that there's no commitment to ship 100% localization outside of French and German.

Comment 7

[Johann Hofmann [:johannh]]

I don't think this is something that needs to go into 70 personally, 71 is fine for this. Let's not stress the process more than necessary.

Comment 8

[Betsy Mikel [:betsymi]]

Yes, 71 is fine. Thank you.

Comment 9

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Bug 1578831 - Link directly to breakage report subview when ETP is off. r=timhuang!

Comment 10

[(inactive) Nihanth Subramanya [:nhnt11]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=22db0b70dddb0119dd2441f6961f98d1457ea691

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8c3fd95b4e26
Link directly to breakage report subview when ETP is off. r=timhuang,fluent-reviewers,flod

Comment 12

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/8c3fd95b4e26