Closed Bug 1578867 Opened 5 years ago Closed 5 years ago

Ensure toolbar UI state is per tab

Categories

(DevTools :: Responsive Design Mode, task, P3)

Product:
DevTools
Component:
Responsive Design Mode
Type:
task

Tracking

(Not tracked)

Status:
RESOLVED INVALID

People

(Reporter: mtigley, Assigned: mtigley)

References

(Blocks 1 open bug)

Details

We want to make sure that each tab with RDM active remembers its local state whenever simulating a new device, viewport size, etc...

Priority: -- → P3

To clarify, the embedded RDM toolbar needs to remember its settings per tab. The Responsive UI manager creates a single iframe to hold the toolbar content, which is acting as a single React app across all the browser tabs. Currently, we are toggling its visibility depending on whether or not RDM is active per tab.

We'll need to think about getting the current tab's settings and communicating this to the toolbar UI every time the user switches between tabs that have RDM open.

Assignee: nobody → mtigley
Status: NEW → ASSIGNED

Given the review feedback in D45091 we will be moving the RDM toolbar frame into each individual .browserContainer rather than rendering for the whole browser window. So this will likely not be an issue anymore.

Let's close this bug and re-open if necessary.

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Depends on: 1578824
Resolution: --- → MOVED

This bug was resolved as MOVED but there's no corresponding see also value pointing to another bug tracker.

The MOVED resolution is only for bugs which are now being managed on external trackers.

Flags: needinfo?(mtigley)

I see. My apologies. I'll mark this appropriately.

Marking this as INVALID since work on Bug 1578824 will resolve this.

Flags: needinfo?(mtigley)
Resolution: MOVED → INVALID
No longer depends on: 1578824
You need to log in before you can comment on or make changes to this bug.