1578932 - doc shell for out-of-process iframe is not inactive in the case where the corresponding display item for the iframe is not built in the first place

Status: RESOLVED FIXED

(Core :: Layout, defect, P2)

Description

[Hiroyuki Ikezoe (:hiro)]

Attachment: A mochitest to see the issue

For example;

<div style="height: 300px; overflow: scroll;">
<div style="height: 5000px;"></div>
<iframe fission="true" ...></iframe>
</div>

above case we don't generate the display item for the iframe, so we don't call UpdateEffects() at all.

Attaching file is a mochitest to see the issue easily.

Comment 1

[Hiroyuki Ikezoe (:hiro)]

:mattwoodrow, where is the right place to call UpdateEffects with FullyHidden EffectsInfo?

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Beware of me trying to change the default visibility of docshells in bug 1572798, though there's some orange I haven't had the chance to go back to.

But It may be a better way to handle this...

Comment 3

[Hiroyuki Ikezoe (:hiro)]

Oh nice. That's good to know. Setting inactive in the first place seems to work at least for out-of-process shells.

Comment 4

[Hiroyuki Ikezoe (:hiro)]

After some more thought, the example in comment 0 is not appropriate. Even if the iframe is far from the display port boundaries, the iframe's doc shell should be active. But if the iframe is under a deck pack which is not selected in the first place, the iframe's doc shell should be inactive, I think. It's the case in bug 1541256.

Comment 5

[Hiroyuki Ikezoe (:hiro)]

Maybe I am wrong. It's not yet clear to me what the active means, if it means whether the doc shell is visible or invisible, the example in comment 0 is still applicable.

Comment 6

[Chris Peterson [:cpeterson]]

Hiro, is this bug still a problem?

If this bug as been fixed since you reported, should we land the new mochitest you posted in comment 0?

Comment 7

[Hiroyuki Ikezoe (:hiro)]

Looks like now the test works fine. Yeah, it's time to land it.

Comment 8

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1578932 - Add a mochitest to check the docshell for an OOP iframe which is out of the display port. r?mattwoodrow

Comment 9

[Chris Peterson [:cpeterson]]

In that case, we'll track this bug for Fission Nightly (M6).

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f588a463cc5a
Add a mochitest to check the docshell for an OOP iframe which is out of the display port. r=mattwoodrow

Comment 11

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/f588a463cc5a