Closed Bug 1578932 Opened 5 years ago Closed 4 years ago

doc shell for out-of-process iframe is not inactive in the case where the corresponding display item for the iframe is not built in the first place


(Core :: Layout, defect, P2)




Fission Milestone M6
Tracking Status
firefox76 --- fixed


(Reporter: hiro, Assigned: hiro)


(Blocks 1 open bug)



(2 files)

For example;

<div style="height: 300px; overflow: scroll;">
<div style="height: 5000px;"></div>
<iframe fission="true" ...></iframe>

above case we don't generate the display item for the iframe, so we don't call UpdateEffects() at all.

Attaching file is a mochitest to see the issue easily.

:mattwoodrow, where is the right place to call UpdateEffects with FullyHidden EffectsInfo?

Flags: needinfo?(matt.woodrow)

Beware of me trying to change the default visibility of docshells in bug 1572798, though there's some orange I haven't had the chance to go back to.

But It may be a better way to handle this...

Oh nice. That's good to know. Setting inactive in the first place seems to work at least for out-of-process shells.

After some more thought, the example in comment 0 is not appropriate. Even if the iframe is far from the display port boundaries, the iframe's doc shell should be active. But if the iframe is under a deck pack which is not selected in the first place, the iframe's doc shell should be inactive, I think. It's the case in bug 1541256.

Maybe I am wrong. It's not yet clear to me what the active means, if it means whether the doc shell is visible or invisible, the example in comment 0 is still applicable.

Hiro, is this bug still a problem?

If this bug as been fixed since you reported, should we land the new mochitest you posted in comment 0?

Flags: needinfo?(matt.woodrow) → needinfo?(hikezoe.birchill)

Looks like now the test works fine. Yeah, it's time to land it.

Assignee: nobody → hikezoe.birchill
Flags: needinfo?(hikezoe.birchill)

In that case, we'll track this bug for Fission Nightly (M6).

Fission Milestone: --- → M6
Pushed by
Add a mochitest to check the docshell for an OOP iframe which is out of the display port. r=mattwoodrow
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla76
You need to log in before you can comment on or make changes to this bug.