1578947 - Add the ability to know when content is first painted (First Contentful Paint event)

Status: RESOLVED FIXED

(GeckoView :: General, enhancement, P2)

Description

[Randall Barker [:rbarker]]

In FxR the surface is first cleared with a transparent color. This means that waiting for the first paint callback doesn't actually indicate when content has been painted an windows are transparent when first shown until content is actually painted. Adding the ability to know when content has been painted would allow us to delay showing the window and associated UI until there is something to display.

Comment 1

[Chris Peterson [:cpeterson]]

James suggests listening for First Contentful Paint event. This should help remove white flashes on page loads.

Comment 3

[Randall Barker [:rbarker]]

Attachment: Bug 1578947 - Add onFirstContentfulPaint() to GeckoView#ContentDelegate

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/16f534a22bc6
Add onFirstContentfulPaint() to GeckoView#ContentDelegate r=geckoview-reviewers,smaug,agi,snorp

Comment 5

[Arthur Iakab [arthur_iakab]]

Backed out changeset 16f534a22bc6 (bug 1578947) for causing lint failure on ServoCSSPropList.py CLOSED TREE

Backout revision https://hg.mozilla.org/integration/autoland/rev/924314a8cff6b27c7fe42f94ea262a5c4e04a28d

Failed push https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=267326381&resultStatus=testfailed%2Cbusted%2Cexception&revision=16f534a22bc6684c745259216f3332900607ed5c&searchStr=linting%2Copt%2Candroid%2Cgradle%2Ctests%2Csource-test-mozlint-android-lints%2Ca%28lints%29

Failure logs https://treeherder.mozilla.org/logviewer.html#?job_id=267326381&repo=autoland

Randall can you please take a look?

Comment 6

[Randall Barker [:rbarker]]

That has nothing to do with my patch. But phabricator seems to be having issues. It was nearly impossible to even get my patch queue.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e979b0b05541
Add onFirstContentfulPaint() to GeckoView#ContentDelegate r=geckoview-reviewers,smaug,agi,snorp

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/e979b0b05541

Comment 9

[Chris Peterson [:cpeterson]]

firefox70=wontfix because we don't need to uplift to GV 70 Beta. FxR needs this onFirstContentfulPaint patch, but FxR has it now because FxR still uses GV Nightly.