1579007 - Revisit Captive Portal UI logic and improve tests

Status: NEW

(Core :: Networking, enhancement, P3)

Description

[(inactive) Nihanth Subramanya [:nhnt11]]

Presently, when there is no active browser window when a portal is detected, we trigger a recheck when a window is opened/gets focused. Then, if the recheck completes quickly and we're still captive, we open a captive portal tab.

This is kinda useless because once we're captive, CaptiveDetect.jsm polls until we're free, and the recheck doesn't actually do anything. We should remove this logic and simply open a captive portal tab immediately.

I'm also going to take the opportunity to improve the tests and write a fake portal sjs script and a simple login page and use those to simulate a captive portal environment.

The test should help catch stuff like bug 1578633.

Comment 1

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Bug 1579007 - Revisit Captive Portal UI logic and improve tests. r=MattN

Comment 2

[(inactive) Nihanth Subramanya [:nhnt11]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=eac8cb989fa8199b0c4ee710ae4ed84d44391b65

Attempt to fix seemingly intermittent failures: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b4b5901d91a00199ccc39c661752a4a2c449f4e0

Another attempt: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c774b2c5d8e29a8e12150d409d92a41d6e6973a4

Comment 3

[(inactive) Nihanth Subramanya [:nhnt11]]

The tests fail as expected without the patch from bug 1578633.

Comment 4

[(inactive) Nihanth Subramanya [:nhnt11]]

The work I was doing last year was abandoned.