1579023 - Speculative connection check prompts PIN if there is non-removable HSM

Status: RESOLVED FIXED

(Core :: Networking, defect, P2)

Description

[Daiki Ueno [:ueno]]

Bug 910207 introduced an additional precondition for speculative connection, which checks (in this order):

1. if there is any smartcards attached or
2. if there is a private key (used for client auth) in the NSS database

However, for some HSM's (e.g., SoftHSM), (1) is not sufficient and that leads to a random PIN prompt appearing at (2).

The reason is that (1) only checks if there is any removable slot, but if there is an "unfriendly" token, NSS still tries to authenticate. I guess that a fix would be to tighten (1) with the check for unfriendly token. I'm attaching a patch along these lines.

For more details, see:
https://bugzilla.mozilla.org/show_bug.cgi?id=1577803#c0

Comment 1

[Daiki Ueno [:ueno]]

Attachment: Bug 1579023, disable preconnect if there is an unfriendly token

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/742ff7d024e7
disable preconnect if there is an unfriendly token r=keeler

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/742ff7d024e7