1579084 - Remove dead netwerk/protocol/websocket/IPCTransportProvider code

Status: RESOLVED WONTFIX

(Core :: Networking: WebSockets, enhancement, P3)

Description

[Christian Holler (:decoder)]

The code in netwerk/protocol/websocket/IPCTransportProvider.(cpp|h) is dead and untested (reported by reviewbot), we should remove it if it is no longer required.

Comment 1

[Dragana Damjanovic [:dragana]]

Michal, do you know if this is used/needed?

Comment 2

[Michal Novotny [:michal]]

It was used by FlyWeb, which I think isn't used anymore. If it's true, we should remove also all server side code from WebSockets, i.e. everything around mServerSide in WebSocketChannel.

Comment 3

[Mahak]

hey @Christian !!
I would like to work on this .
It would be great if you could you please elaborate this more .
Thanks :)
Mahak

Comment 4

[Igor [:ExplodingJoysticks]]

Attachment: Bug 1579084 - Remove unused FlyWeb TransportProvider code, and code related to WebSocket ServerSide r?#necko-reviewers

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Hi Valentin, given that we cannot move forward with the removal of the transport because it's used for WebSocket upgrade paths how to continue on this bug?

Comment 6

[Valentin Gosu [:valentin] {{PTO until Nov 1st}}]

It would seem that comment 0 is no longer valid, and we actually have consumers for the transport code.
Let's close it for now.
@ExplodingJoysticks - sorry you spent time on this without being able to land it. Thank you for the effort you put in.

Comment 7

[Igor [:ExplodingJoysticks]]

(In reply to Valentin Gosu [:valentin] from comment #6)

It would seem that comment 0 is no longer valid, and we actually have consumers for the transport code.
Let's close it for now.
@ExplodingJoysticks - sorry you spent time on this without being able to land it. Thank you for the effort you put in.

Don't worry about it, I'm glad the bug is be closed regardless.