1579154 - make ujet/newtab unit tests report back to main phab review screen

Status: NEW

(Firefox :: Messaging System, task, P3)

Description

[Dan Mosedale (:dmosedale, :dmose)]

Right now, the newtab/messaging unit tests are automatically kicked off by Phabricator when a patch touching browser/components/newtab is uploaded. To see the results from the main review page, one has to click through the "Treeherder Jobs" link and then wait for and watch the newtab task results in treeherder. This means that those results are often missed by the developer and/or reviewer in question.

We should make them show up in the main Phabricator review page by outputting the appropriate json, and working with the static analysis team to get it connected (which should be easy).

Edited excerpt from a chat log about how to do this:

dmosedale: so if we start producing the mozlint format as you describe
in https://bugzilla.mozilla.org/show_bug.cgi?id=1575295#c2, the code review bot
should automatically recognize it and put the results in phab?

Bastien: i'll need to make some small changes, but it will be easy & fast

dmosedale: ok, are there docs about where to put this JSON file we produce?

Bastien: sorry, no docs for now, it's on my roadmap for the next few weeks
but you "just" need to produce a Taskcluster public artifact
so your task needs to write the json file in a dir, let's say /output/review.json
and your task declaration must expose that path as a public artifact
like here:
https://hg.mozilla.org/mozilla-central/file/tip/taskcluster/ci/source-test/clang.yml#l59