1579165 - Separators between logins (and bounding boxes of containers) should be lighter to match the spec

Status: VERIFIED FIXED

(Firefox :: about:logins, defect, P3)

Description

[David Durst [:ddurst]]

The border associated with the sidebar, header, etc are using --in-content-box-border-color (which is rgba(12,12,13,0.3)). They should use #d7d7db (or rgba(12,12,13,0.2) if that supports light/dark modes better).

Comment 1

[Tim Nguyen :ntim]

FWIW, --in-content-border-color is set to #d7d7db, which is the color we want here. It should be correct semantically too as long as we don't associate it with --in-content-box-background.

Comment 2

[Maxx Crawford [:maxx]]

Attachment: Bug 1579165 - Separators between logins (and bounding boxes of containers) should be lighter to match the spec r?jaws

Note - I did not edit the refernces to --in-content-box-border-color across the following refernces:
login-list:
:host (Also contained references to backround color: --in-content-box-background)
.meta (Also contained references to backround color: --in-content-box-background)
.create-login-button-container (Shadow color property)
menu-button:
.menu (Also contained references to backround color: --in-content-box-background)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a214efa56e4d
Separators between logins (and bounding boxes of containers) should be lighter to match the spec r=jaws

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/a214efa56e4d

Comment 5

[Simona Rosu [:srosu], Ecosystem QA]

I have verified this issue on the latest Nightly 71.0a1 (Build ID: 20191016212918) on Windows 10 x64, Mac 10.14, Ubuntu 16.04 x64.

• The separators between logins and dividing lines between the sections are lighter.
• The “1px solid var(--in-content-box-border-color);” is changed to “border-bottom: 1px solid var(--in-content-border-color);” and the color is #d7d7db.