1579178 - Handle full-page zooming for embedded RDM UI

Status: RESOLVED FIXED

(DevTools :: Responsive Design Mode, task, P1)

Description

[Micah [:mtigley] (she/her)]

Make sure that full-page zooming is working correctly for the embedded RDM UI.

Comment 1

[Brad Werth [:bradwerth]]

Attachment: Bug 1579178 Part 1: Make RDM new browser ui change viewport size in response to zoom.

Comment 2

[Brad Werth [:bradwerth]]

It looks like this will require a similar resolution save-and-restore that was done for the old RDM in Bug 1561227. I'm looking for the right place to add the PreFullZoomChange listener.

Comment 3

[Brad Werth [:bradwerth]]

Attachment: Bug 1579178 Part 2: Move the full zoom save-and-restore of resolution into the ZoomActorChild.

For the existing RDM UI, te saving and restoring of resolution is done
in the content frame script, which is no longer loaded in the new UI.
This approach is flexible enough that it should work for BOTH UIs.
Another patch will contain the removal of the old method.

Depends on D54379

Comment 4

[Brad Werth [:bradwerth]]

Attachment: Bug 1579178 Part 3: Remove the old RDM UI method for save-and-restore of resolution for full zoom changes.

Depends on D56267

Comment 5

[Brad Werth [:bradwerth]]

Attachment: Bug 1579178 Part 4: Update test functions and an existing zoom test to work with new RDM UI.

Depends on D56509

Comment 6

[Brad Werth [:bradwerth]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=730edbcfc08b94d98534cd5891f8e78e8c4bf426

Comment 7

[Brad Werth [:bradwerth]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b30f4d00c856449929d207dd647aa670b04e116f

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b51ab5405feb
Part 1: Make RDM new browser ui change viewport size in response to zoom. r=mtigley
https://hg.mozilla.org/integration/autoland/rev/82a2871f7314
Part 2: Move the full zoom save-and-restore of resolution into the ZoomActorChild. r=mconley
https://hg.mozilla.org/integration/autoland/rev/cb346b488c26
Part 3: Remove the old RDM UI method for save-and-restore of resolution for full zoom changes. r=mtigley
https://hg.mozilla.org/integration/autoland/rev/930e05cfb152
Part 4: Update test functions and an existing zoom test to work with new RDM UI. r=mtigley

Comment 9

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/b51ab5405feb
https://hg.mozilla.org/mozilla-central/rev/82a2871f7314
https://hg.mozilla.org/mozilla-central/rev/cb346b488c26
https://hg.mozilla.org/mozilla-central/rev/930e05cfb152