Closed
Bug 1579227
Opened 5 years ago
Closed 5 years ago
YUV images seem to be drawn in the transparency pass
Categories
(Core :: Graphics: WebRender, enhancement, P3)
Core
Graphics: WebRender
Tracking
()
RESOLVED
FIXED
mozilla71
People
(Reporter: jrmuizel, Assigned: kvark)
References
Details
Attachments
(1 file)
47 bytes,
text/x-phabricator-request
|
lizzard
:
approval-mozilla-beta+
|
Details | Review |
Looking at youtube drawing this came up. Drawing them opaquely would be better.
Reporter | ||
Updated•5 years ago
|
Assignee: nobody → dmalyshau
Assignee | ||
Comment 1•5 years ago
|
||
Pushed by dmalyshau@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3bcc094e0863 Switch YUV images to be opaque in WR r=jrmuizel
Comment 3•5 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox71:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
Assignee | ||
Comment 4•5 years ago
|
||
Comment on attachment 9091074 [details]
Switch YUV images to be opaque in WR
Beta/Release Uplift Approval Request
- User impact if declined: Bad performance on large video elements.
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): In the worst case, we'd see some of the video elements rendered incorrectly, and it's trivial to switch back.
- String changes made/needed:
Attachment #9091074 -
Flags: approval-mozilla-beta?
Comment 5•5 years ago
|
||
Comment on attachment 9091074 [details]
Switch YUV images to be opaque in WR
Video perf issue for YouTube/WebRender.
OK for uplift for beta 6. Let's verify in beta.
Attachment #9091074 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Updated•5 years ago
|
Flags: qe-verify+
Updated•5 years ago
|
QA Whiteboard: [qa-triaged]
Comment 7•5 years ago
|
||
Hi Jeff,
I suppose this is part of fixing Bug 1569767 regarding the increased GPU usage for Intel Webrender.
Is there any way we could verify this fix now (simplified testcase) or we should wait until Bug 1579235 is also fixed and check out the GPU usage on Youtube?
Flags: needinfo?(jmuizelaar)
Reporter | ||
Comment 8•5 years ago
|
||
I don't think there's any easy way to verify this. I'd recommend not worrying about it.
Flags: needinfo?(jmuizelaar)
Comment 9•5 years ago
|
||
Thanks, Jeff!
Removing qe-verify+ verify flag based on Comment 8.
QA Whiteboard: [qa-triaged]
Flags: qe-verify+
You need to log in
before you can comment on or make changes to this bug.
Description
•