1579227 - YUV images seem to be drawn in the transparency pass

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P3)

Description

[Jeff Muizelaar [:jrmuizel]]

Looking at youtube drawing this came up. Drawing them opaquely would be better.

Comment 1

[Dzmitry Malyshau [:kvark]]

Attachment: Switch YUV images to be opaque in WR

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3bcc094e0863
Switch YUV images to be opaque in WR r=jrmuizel

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/3bcc094e0863

Comment 4

[Dzmitry Malyshau [:kvark]]

Comment on attachment 9091074 [details]
Switch YUV images to be opaque in WR

Beta/Release Uplift Approval Request

• User impact if declined: Bad performance on large video elements.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): In the worst case, we'd see some of the video elements rendered incorrectly, and it's trivial to switch back.
• String changes made/needed:

Comment 5

[Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 9091074 [details]
Switch YUV images to be opaque in WR

Video perf issue for YouTube/WebRender.
OK for uplift for beta 6. Let's verify in beta.

Comment 6

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/a23c865aef7f

Comment 7

[Timea Cernea [:tbabos][inactive]]

Hi Jeff,

I suppose this is part of fixing Bug 1569767 regarding the increased GPU usage for Intel Webrender.
Is there any way we could verify this fix now (simplified testcase) or we should wait until Bug 1579235 is also fixed and check out the GPU usage on Youtube?

Comment 8

[Jeff Muizelaar [:jrmuizel]]

I don't think there's any easy way to verify this. I'd recommend not worrying about it.

Comment 9

[Timea Cernea [:tbabos][inactive]]

Thanks, Jeff!
Removing qe-verify+ verify flag based on Comment 8.