1579319 - Distinguish objects and frames from different locations

Status: RESOLVED FIXED

(Core Graveyard :: Web Replay, enhancement)

Description

[Brian Hackett [Laid off!]]

Right now, ReplayDebugger objects, frames, and so forth are associated with the current pause, and have their contents cleared out so that they are unusable when the debugger unpauses. It would be nice to improve this behavior, so that objects can be used even when the debugger is not paused at the point they came from.

The immediate need for this is to improve handling of messages logged by the console and logpoints. Right now we have a separate ReplayDebuggerObjectSnapshot class for this, but it is clunky, duplicates functionality from the normal object case, and only works well with vanilla objects and arrays. By distinguishing objects logged to the console from objects that are part of some debugger pause, we can use normal ReplayDebuggerObjects in the former case. Logged objects still can't be fully inspected (we can't send queries to the replaying process to access contents not included in the preview) but this functionality could be extended in the future to support that.

Comment 1

[Brian Hackett [Laid off!]]

Attachment: Bug 1579319 - Distinguish objects and frames from different locations, r=jlast.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5469ca5999ab
Distinguish objects and frames from different locations, r=jlast.

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/5469ca5999ab