Closed Bug 1579425 Opened 5 years ago Closed 5 years ago

update profiler_helper's object and goblin dependencies

Categories

(Core :: Gecko Profiler, task, P3)

task

Tracking

()

RESOLVED FIXED
mozilla71
Tracking Status
firefox71 --- fixed

People

(Reporter: froydnj, Assigned: eijebong)

References

Details

Attachments

(2 files)

We're trying to pull in some crates for wasm sandboxing and discovered they depend on newer versions of object and goblin. Since we don't really want multiple copies of these crates in tree, it'd be good to update profiler_helper to depend on newer versions.

(backtrace depends on different versions of object and goblin...but somehow we only have one copy of each of object and goblin in the tree. I do not understand why this is. Ideally when we update profiler_helper, we won't magically find ourselves with two versions of these crates in-tree...)

Bastien, are you interested in updating these crates?

Flags: needinfo?(eijebong)

I had a patch somewhere to dedupe rand which updated those and I totally forgot about it. I'll have a look at it later today.

Flags: needinfo?(eijebong)
Pushed by eijebong@bananium.fr: https://hg.mozilla.org/integration/autoland/rev/2a3eff133e23 Part 1: Update goblin and object. r=froydnj https://hg.mozilla.org/integration/autoland/rev/782406529ec4 Part 2: Revendor dependencies. r=froydnj
Assignee: nobody → eijebong
Priority: -- → P3
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: