1579526 - Wrong screen sharing preview (regression)

Status: VERIFIED FIXED

(Core :: WebRTC: Audio/Video, defect, P2)

Description

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

The screen sharing preview always shows the first window in the list.

STRs:

1. Open https://jan-ivar.github.io/dummy/gdm.html
2. In the popup, select a window that is not the first entry and not "Entire screen".

Expected result:

• Preview of the window selected

Actual result:

• Preview of the first window in the list

Regression range:

0:54.08 INFO: Narrowed inbound regression window from [546d1fd4, c8b9ae70] (3 builds) to [546d1fd4, 73353f37] (2 builds) (~1 steps left)
0:54.08 INFO: No more inbound revisions, bisection finished.
0:54.08 INFO: Last good revision: 546d1fd47c9a48b6919848b2c6f28359460731eb
0:54.08 INFO: First bad revision: 73353f375d1dda3d4ff434da2a4f7bdfd39d3422
0:54.08 INFO: Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=546d1fd47c9a48b6919848b2c6f28359460731eb&tochange=73353f375d1dda3d4ff434da2a4f7bdfd39d3422

Comment 1

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

[Tracking Requested - why for this release]: Regressed behavior

Comment 2

[Andreas Pehrson [:pehrsons]]

Do we secretly use a deviceId constraint internally to signal which screen or window is desired? Because I can see how that would be a regression from bug 1571667.

That is a bit ugly. Device ids follow the spec, and the spec simply doesn't allow device id constraints for display media.

I guess we need to deviceId constraints allowed for display media when the request is from chrome.

Comment 3

[Andreas Pehrson [:pehrsons]]

That is indeed what we are doing.

Comment 4

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1579526 - Allow deviceId and groupId constraints for privileged getDisplayMedia callers. r?jib

Comment 5

[Pascal Chevrel:pascalc]

Tracking as we may need to uplift a fix to 70 beta.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6622664a239e
Allow deviceId and groupId constraints for privileged getDisplayMedia callers. r=jib

Comment 7

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/6622664a239e

Comment 8

[Andreas Pehrson [:pehrsons]]

Comment on attachment 9091403 [details]
Bug 1579526 - Allow deviceId and groupId constraints for privileged getDisplayMedia callers. r?jib

Beta/Release Uplift Approval Request

• User impact if declined: Users will see the wrong screen/window share preview in most cases of requesting screen/window sharing.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See comment 0.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Trivial change.
• String changes made/needed:

Comment 9

[Adrian Florinescu [:aflorinescu]]

Reproduced the bug on 70.0b5 20190909162732 (where fix hasn't been uplifted yet), confirmed that it works as expected on 69.0 20190827005903, which is unaffected by the bug and verified the landed fix on:

71.0a1 2019-09-12 on Windows 7, Mac 10.14.6 and Ubuntu 16.04

Comment 10

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9091403 [details]
Bug 1579526 - Allow deviceId and groupId constraints for privileged getDisplayMedia callers. r?jib

Fix for new regression in 70, verified in nightly. OK for uplift for beta 7.

Comment 11

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/releases/mozilla-beta/rev/64d8ad1c9962

Comment 12

[Alin Ilea, Desktop Test Engineering]

Reproduced the issue using an old beta build 70.0b5 (Build id: 20190909162732).
Verified - fixed in Beta 70.0b7 (Build id: 20190916074538) and latest Nightly 75.0a1 (2020-02-11). Based on this I will update the flags accordingly.
Thanks.