Closed Bug 1579540 Opened 2 months ago Closed Last month

Migrate a single entity from browser.dtd to ftl to test out the migration process in browser.xhtml

Categories

(Firefox :: General, task, P1)

task

Tracking

()

VERIFIED FIXED
Firefox 71
Tracking Status
firefox71 --- fixed

People

(Reporter: bgrins, Assigned: bgrins)

References

(Blocks 1 open bug)

Details

Attachments

(2 files, 1 obsolete file)

This string looks like a good candidate. Only used once for a single attribute: https://searchfox.org/mozilla-central/search?q=urlbar.viewSiteInfo.label&path=.

There's a script that's intended to help here, so let's try it out and see what happens: https://searchfox.org/mozilla-central/source/python/l10n/convert_xul_to_fluent/convert.py.

The main question I have is where the string should go. We don't yet have an ftl file for "strings used only in the browser window" (https://searchfox.org/mozilla-central/rev/05db7b82d5a4adaa8b36ec6f4fd1715f6fd7885b/browser/base/content/browser.xhtml#76-78), so perhaps adding a browser.ftl with the new string makes sense.

I suggest browser.ftl and browser-urlbar-identity-button with an .aria-label attribute.

Depends on: 1579550

Comment on attachment 9091544 [details]
Bug 1579540 - Part2: Always provide autoSavedLoginGuid to promptToChangePassword when available. r?MattN

Revision D45239 was moved to bug 1579539. Setting attachment 9091544 [details] to obsolete.

Attachment #9091544 - Attachment is obsolete: true
Assignee: nobody → bgrinstead
Priority: -- → P1
Pushed by bgrinstead@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7adb8074caaa
Introduce browser.ftl and load it in browser.xhtml r=fluent-reviewers,flod
https://hg.mozilla.org/integration/autoland/rev/e5e2f123bdcc
Migrate urlbar.viewSiteInfo.label from dtd to ftl r=fluent-reviewers,flod
Status: NEW → RESOLVED
Closed: Last month
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71

Verified on 71.0a1 (2019-09-12) (64 bit)

Status: RESOLVED → VERIFIED
Blocks: 1580978
You need to log in before you can comment on or make changes to this bug.