Migrate a single entity from browser.dtd to ftl to test out the migration process in browser.xhtml
Categories
(Firefox :: General, task, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox71 | --- | verified |
People
(Reporter: bgrins, Assigned: bgrins)
References
Details
Attachments
(2 files, 1 obsolete file)
This string looks like a good candidate. Only used once for a single attribute: https://searchfox.org/mozilla-central/search?q=urlbar.viewSiteInfo.label&path=.
There's a script that's intended to help here, so let's try it out and see what happens: https://searchfox.org/mozilla-central/source/python/l10n/convert_xul_to_fluent/convert.py.
The main question I have is where the string should go. We don't yet have an ftl file for "strings used only in the browser window" (https://searchfox.org/mozilla-central/rev/05db7b82d5a4adaa8b36ec6f4fd1715f6fd7885b/browser/base/content/browser.xhtml#76-78), so perhaps adding a browser.ftl with the new string makes sense.
Comment 1•5 years ago
|
||
I suggest browser.ftl and browser-urlbar-identity-button
with an .aria-label
attribute.
Comment 2•5 years ago
|
||
Comment 3•5 years ago
|
||
Comment on attachment 9091544 [details]
Bug 1579540 - Part2: Always provide autoSavedLoginGuid to promptToChangePassword when available. r?MattN
Revision D45239 was moved to bug 1579539. Setting attachment 9091544 [details] to obsolete.
Assignee | ||
Comment 4•5 years ago
|
||
Assignee | ||
Comment 5•5 years ago
|
||
Depends on D45466
Updated•5 years ago
|
Pushed by bgrinstead@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7adb8074caaa Introduce browser.ftl and load it in browser.xhtml r=fluent-reviewers,flod https://hg.mozilla.org/integration/autoland/rev/e5e2f123bdcc Migrate urlbar.viewSiteInfo.label from dtd to ftl r=fluent-reviewers,flod
Comment 7•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/7adb8074caaa
https://hg.mozilla.org/mozilla-central/rev/e5e2f123bdcc
Updated•4 years ago
|
Description
•