Closed Bug 1579658 Opened 5 years ago Closed 5 years ago

Hovering on the console jump button should update the viewport

Categories

(Core Graveyard :: Web Replay, enhancement)

enhancement
Not set
normal

Tracking

(firefox71 fixed)

RESOLVED FIXED
mozilla71
Tracking Status
firefox71 --- fixed

People

(Reporter: jlast, Assigned: jlast)

Details

Attachments

(1 file)

When the user hovers on the console jump button of a message that has been cached, we should immediately update the viewport to show what the page looked like at that time.

This can be done by using the paintData associated with the pause data that is retained for each message which can be warped to immediately (the messages that aren't grayed out in the timeline). You can look at repaint() in devtools/server/actors/replay/control.js for how this is currently used; right now the RecordReplayControl.hadRepaint() method is used to update the canvas which has the tab's graphics, but the paintData is just a string which has a base64-encoded PNG image (it would be nice to do this entirely in JS without involving RecordReplayControl, but that will require a little refactoring).

Pushed by jlaster@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b93f753ddfe4
Hovering on the console jump button should update the viewport. r=bhackett
Pushed by jlaster@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3720495e0960
Hovering on the console jump button should update the viewport. r=bhackett
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
Assignee: nobody → jlaster
Flags: needinfo?(jlaster)
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: