1579658 - Hovering on the console jump button should update the viewport

Status: RESOLVED FIXED

(Core Graveyard :: Web Replay, enhancement)

Description

[Jason Laster [:jlast]]

When the user hovers on the console jump button of a message that has been cached, we should immediately update the viewport to show what the page looked like at that time.

Comment 1

[Brian Hackett [Laid off!]]

This can be done by using the paintData associated with the pause data that is retained for each message which can be warped to immediately (the messages that aren't grayed out in the timeline). You can look at repaint() in devtools/server/actors/replay/control.js for how this is currently used; right now the RecordReplayControl.hadRepaint() method is used to update the canvas which has the tab's graphics, but the paintData is just a string which has a base64-encoded PNG image (it would be nice to do this entirely in JS without involving RecordReplayControl, but that will require a little refactoring).

Comment 2

[Jason Laster [:jlast]]

Attachment: Bug 1579658 - Hovering on the console jump button should update the viewport. r=bhackett

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b93f753ddfe4
Hovering on the console jump button should update the viewport. r=bhackett

Comment 4

[Razvan Maries]

Backed out for ES Lint failure.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=b93f753ddfe462469d9ce0b5bc3bf2bd0bf9a96a&selectedJob=266033434&searchStr=Linting%2Copt%2CJavaScript%2Cchecks%2Csource-test-mozlint-eslint%2Cjs%28ES%29

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=266033434&repo=autoland&lineNumber=277

Backout: https://hg.mozilla.org/integration/autoland/rev/aa2920aa9ee5a3f4282a15ec9abdfb227124bd54

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3720495e0960
Hovering on the console jump button should update the viewport. r=bhackett

Comment 6

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/3720495e0960