Closed Bug 1579735 Opened 7 years ago Closed 7 years ago

Let PB windows be identified by backend and themes

Categories

(SeaMonkey :: General, defect)

Product:
SeaMonkey
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(seamonkey2.49esr unaffected, seamonkey2.53 fixed, seamonkey2.57esr fixed, seamonkey2.63 wontfix)

Status:
RESOLVED FIXED
Milestone:
seamonkey2.68
Tracking Flags:
Tracking Status
seamonkey2.49esr --- unaffected
seamonkey2.53 --- fixed
seamonkey2.57esr --- fixed
seamonkey2.63 --- wontfix

People

(Reporter: iannbugzilla, Assigned: iannbugzilla)

References

Details

(Whiteboard: SM2.53.1)

Attachments

(1 file, 2 obsolete files)

Remove the remove v1.2 with extras
3.18 KB, patch
frg
: review+
frg
: approval-comm-release+
frg
: approval-comm-esr60+
Details | Diff | Splinter Review

Prior to the fix on bug 874042, PB windows had their own windowtype but that caused issues with web apps/sites keeping hold of information between windows within the PB session as setting a windowtype caused cookies to be cleared.
Currently, the windowtype is removed completely from a PB window, which causes PB windows not be work properly with RecentWindow.jsm as it does not know how to find them. Also themes have no easy way of theming PB windows.

Attached patch Remove the remove (obsolete) — — Splinter Review

[Approval Request Comment]
Regression caused by (bug #): 874042
User impact if declined: None
Testing completed (on m-c, etc.): 2.53
Risk to taking this patch (and alternatives if risky): None found yet
String changes made by this patch: None

Attachment #9091308 - Flags: review?(frgrahl)
Attachment #9091308 - Flags: approval-comm-release?
Attachment #9091308 - Flags: approval-comm-esr60?
Blocks: 1578067
Attached patch Remove the remove v1.1 (obsolete) — — Splinter Review

Now no longer based on top of WIP patches :)

Attachment #9091308 - Attachment is obsolete: true
Attachment #9091308 - Flags: review?(frgrahl)
Attachment #9091308 - Flags: approval-comm-release?
Attachment #9091308 - Flags: approval-comm-esr60?
Attachment #9091359 - Flags: review?(frgrahl)
Attachment #9091359 - Flags: approval-comm-release?
Attachment #9091359 - Flags: approval-comm-esr60?

OpenBrowserWindow had to be told to open non-private windows

Attachment #9091359 - Attachment is obsolete: true
Attachment #9091359 - Flags: review?(frgrahl)
Attachment #9091359 - Flags: approval-comm-release?
Attachment #9091359 - Flags: approval-comm-esr60?
Attachment #9097198 - Flags: review?(frgrahl)
Attachment #9097198 - Flags: approval-comm-release?
Attachment #9097198 - Flags: approval-comm-esr60?
Comment on attachment 9097198 [details] [diff] [review] Remove the remove v1.2 with extras lgtm With this patch I also was unable to reproduce the orginal issue this patch backs out with cookies cleared so everything seems to fine here too.
Attachment #9097198 - Flags: review?(frgrahl)
Attachment #9097198 - Flags: review+
Attachment #9097198 - Flags: approval-comm-release?
Attachment #9097198 - Flags: approval-comm-release+
Attachment #9097198 - Flags: approval-comm-esr60?
Attachment #9097198 - Flags: approval-comm-esr60+

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/549e605f5eab
Let PB windows be identified by backend and themes. r=frg

Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: SM2.53.1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: