1579752 - Add telemetry product-override flag for testing.

Status: RESOLVED FIXED

(Toolkit :: Telemetry, enhancement, P1)

Description

[Ben Campbell]

Telemetry probes have a "products" field which governs which products they're active for (gecko, fennec etc..).

It'd be nice to have a product-override flag available for tests which enables probes to be used even if the current product is not listed in the "products" field.

This came up mostly in the context of adding "thunderbird" as a telemetry product (Bug 1427877). Relevant discussion at https://phabricator.services.mozilla.com/D44426#1351005

Benefits (over skipping tests based on product):

• some unit tests use telemetry probes to test non-telemetry code (the telemetry provides insight into an otherwise-opaque module).
• it'll be very easy to add firefox-specific probes with new tests, and accidentally break other products without realising.
• the telemetry tests provide extra test coverage of modules, even if some products don't need telemetry data regarding those modules.

Comment 1

[Chris H-C :chutten|PTO (back Jan 5)]

Attachment: Bug 1579752 - Add a testing pref to override Telemetry's products check r?janerik

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2bb2908d7a36
Add a testing pref to override Telemetry's products check r=janerik

Comment 3

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/2bb2908d7a36