Closed Bug 1579774 Opened 3 years ago Closed 2 months ago

[Inactive CSS] Show warning when width / height are used on ruby elements

Categories

(DevTools :: Inspector: Rules, enhancement, P2)

71 Branch
enhancement

Tracking

(firefox-esr68 wontfix, firefox69 wontfix, firefox70 wontfix, firefox71 wontfix, firefox105 fixed)

RESOLVED FIXED
105 Branch
Tracking Status
firefox-esr68 --- wontfix
firefox69 --- wontfix
firefox70 --- wontfix
firefox71 --- wontfix
firefox105 --- fixed

People

(Reporter: mozilla-crowdicity.wadmol, Assigned: rfemailtesting)

References

(Blocks 1 open bug)

Details

(Whiteboard: [Importance: 92.5%])

Attachments

(1 file)

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Firefox/68.0

Steps to reproduce:

  1. Open this fiddle
  2. Inspect the p element

Actual results:

CSS inspector is not showing contextual information that height and width have no effect

Expected results:

Contextual information should still be available

Version: 68 Branch → 71 Branch

Thanks for the report.
Reproduced on 66.0.5 20190507012018, 70.0b5 20190909162732, 71.0a1 20190912215412, 69.0 20190827005903 on Windows 10/ Ubuntu 16.04 so it doesn't seem like a regression.

Component: Untriaged → Inspector: Rules
OS: Unspecified → All
Product: Firefox → DevTools
Hardware: Unspecified → All
Summary: CSS inspector should show warning/contextual information even when display type is set to `ruby` → [Inactive CSS] Show warning/contextual information even when display type is set to `ruby`
Priority: -- → P2
Whiteboard: [Importance: 92.5%]
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: [Inactive CSS] Show warning/contextual information even when display type is set to `ruby` → [Inactive CSS] Show warning when width / height are used on ruby elements

Main file:
devtools/server/actors/utils/inactive-property-helper.js

invalidProperties: [
"width",
"height",
]

inactive-css-ruby-element = <strong>{ $property }</strong> has no effect on this element since it is a ruby element and is calculated by the font size of the ruby text.
inactive-css-ruby-element-fix = Try changing the <strong>font-size</strong> of the ruby text. { learn-more }

Type: defect → enhancement

(In reply to Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe] from comment #2)

inactive-css-ruby-element-fix = Try removing <strong>display:ruby</strong>. { learn-more }

I think we might want to revisit some of our proposed fixes. Here for instance, if the author chose to define display:ruby then they probably meant to do this, and are not likely to want to remove this display value. Instead they're looking for a way to make width/height work. So we should help them do that instead.

Also, I want to question the [Importance: 92.5%] whiteboard flag. This importance was set based on the fact that width and height are very common properties. But ruby is not as common at all. We should base the importance of this bug based on ruby rather than width/height.

(In reply to Patrick Brosset <:pbro> from comment #3)

(In reply to Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe] from comment #2)

inactive-css-ruby-element-fix = Try removing <strong>display:ruby</strong>. { learn-more }

I think we might want to revisit some of our proposed fixes. Here for instance, if the author chose to define display:ruby then they probably meant to do this, and are not likely to want to remove this display value. Instead they're looking for a way to make width/height work. So we should help them do that instead.

You can't change the size of a ruby box because it is calculated by the size of the glyphs (characters in e.g. Korean). Because there is no way to change the width and height I suppose we could suggest changing the font-size... I'll change the fix text.

Also, I want to question the [Importance: 92.5%] whiteboard flag. This importance was set based on the fact that width and height are very common properties. But ruby is not as common at all. We should base the importance of this bug based on ruby rather than width/height.

That depends on your region... in Asia, Israel and Arabic speaking countries ruby boxes are used all the time. We could lower the value although we also need to keep our international friends in mind.

Assignee: nobody → rfemailtesting
Status: NEW → ASSIGNED

This is in review

Flags: needinfo?(jdescottes)

Sorry, there was a problem with the detection of inactive users. I'm reverting the change.

Assignee: nobody → rfemailtesting
Status: NEW → ASSIGNED
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/11aee184972f
New inactive CSS rule to show warning when width or height is used on ruby element. r=nchevobbe,fluent-reviewers
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 105 Branch
You need to log in before you can comment on or make changes to this bug.