1579807 - Crash in [@ nsBaseWidget::NotifyLiveResizeStarted]

Status: NEW

(Core :: Widget, defect, P3)

Description

[Gabriele Svelto [:gsvelto] (PTO)]

This bug is for crash report bp-17c2d436-d983-455a-8b8c-3b42b0190907.

Top 10 frames of crashing thread:

0 XUL nsBaseWidget::NotifyLiveResizeStarted widget/nsBaseWidget.cpp:2055
1 AppKit AppKit@0x333623 
2 AppKit AppKit@0x33372a 
3 AppKit AppKit@0x33372a 
4 AppKit AppKit@0x333586 
5 AppKit AppKit@0x333471 
6 AppKit AppKit@0x6a8f72 
7 AppKit AppKit@0x94b7e9 
8 AppKit AppKit@0xad96d4 
9 XUL nsCocoaWindow::DoMakeFullScreen widget/cocoa/nsCocoaWindow.mm:1440

This is a NULL-pointer dereference happening here:

https://hg.mozilla.org/mozilla-central/annotate/7f0c7ef868ff063e9953b4a1111f3b96da9cd335/widget/nsBaseWidget.cpp#l2055

It seems to affect at least Windows and macOS.

Comment 1

[Mats Palmgren (inactive)]

Hmm, I wonder if this is "just" a null-pointer crash or if we were just lucky in the reports so far...

Markus, you reviewed bug 1328066 so I assume you're somewhat familiar with this code?
Can you take a look please?

Comment 2

[Andrew McCreight [:mccr8]]

This still seems to be happening. There was a recent batch of these on Nightly with the odd signature [@ aom_smooth_v_predictor_32x8_c]

There's a bit more to go on now than maybe there was a few years ago, as a few of these crash (like bp-bee95875-340a-4cea-95a8-667b60211021) have things like this in their Mac Crash Info:

      "message": "Performing @selector(_setNeedsZoom:) from sender _NSThemeZoomWidget 0x121f41200",
      "module": "/System/Library/Frameworks/AppKit.framework/Versions/C/AppKit"

This report also has the comment: "Whenever I restart Nightly after an update, it appears as if my tabs are back, but there’s only a white screen. Whenever I click on a tab or the search bar, it only highlights them. If I try to make Nightly fullscreen, the browser ends up crashing."

Comment 3

[Andrew McCreight [:mccr8]]

Ah, right. Some of these crashes are actually still on Windows. But maybe the Mac angle has some promise.

Comment 4

[Andrew McCreight [:mccr8]]

I added that signature here because I saw some other crashes under this signature with the same Mac Crash Info, but maybe it is a separate issue.