1579845 - Add unit tests for the various mozlint rules that we have

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, task)

Comment 1

[Andrew Halberstadt [:ahal]]

Note, I'm in the process of converting mozlint to Python 3. So it might help to either:

A) Block on that to avoid extra conversion work (bug 1567642)
B) Make sure the tests are Python 3 compatible (you won't be able to test this unfortunately until the above lands)

Comment 2

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1579845 - Add a test to the mozlint check: file-perm r?ahal

Comment 3

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1579845 - Add a test to the mozlint check: file-whitespace r?ahal

Depends on D45444

Comment 4

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1579845 - Add a test to the mozlint check: codespell r?ahal

Depends on D45445

Comment 5

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1579845 - Ride along: Add the line number in the file whitespace lint r?ahal

Depends on D45446

Comment 6

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1579845 - ride along: Strip codespell results r?ahal

Depends on D45447

Comment 7

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1579845 - ride along: treeherder: Rename ml to mozlint r?ahal

ML now means Machine Learning for most people, we should be more explicit for new comers

Depends on D45449

Comment 8

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1579845 - ride along: codespell Add support of exclude: r?ahal

Depends on D45449

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/18f2c53f2f71
Add a test to the mozlint check: file-perm r=ahal
https://hg.mozilla.org/integration/autoland/rev/8b1d6ad6acdc
Add a test to the mozlint check: file-whitespace r=ahal

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9c621b8602f1
Ride along: Add the line number in the file whitespace lint r=ahal

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e864f41e1829
ride along: Strip codespell results r=ahal
https://hg.mozilla.org/integration/autoland/rev/b4a2b9704d61
ride along: treeherder: Rename ml to mozlint r=ahal

Comment 12

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/18f2c53f2f71
https://hg.mozilla.org/mozilla-central/rev/8b1d6ad6acdc
https://hg.mozilla.org/mozilla-central/rev/9c621b8602f1
https://hg.mozilla.org/mozilla-central/rev/e864f41e1829
https://hg.mozilla.org/mozilla-central/rev/b4a2b9704d61

Comment 13

[Sylvestre Ledru [:Sylvestre]]

Other things are coming

Comment 14

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1579845 - Add a test to the mozlint check: license r?ahal

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f698c4b34515
Add a test to the mozlint check: license r=ahal

Comment 16

[Arthur Iakab [arthur_iakab]]

Backed out changeset f698c4b34515 (bug 1579845) for causing lint failure on foobar.js CLOSED TREE

Backout revision https://hg.mozilla.org/integration/autoland/rev/9e69eb28064b15f75150f941fa37c5e802398402

Failed push https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=266868388&resultStatus=testfailed%2Cbusted%2Cexception&revision=f698c4b345157f457f416d40df66c6b0a55e12bc&searchStr=linting%2Copt%2Cpedantic%2Cchecks%2Csource-test-mozlint-license%2Cpedantic%28license%29

Failure log https://treeherder.mozilla.org/logviewer.html#?job_id=266868388&repo=autoland

Sylvestre can you please take a look?

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d8091d350d7c
Add a test to the mozlint check: license r=ahal

Comment 18

[Sylvestre Ledru [:Sylvestre]]

Fixed (I am ignoring the tests)

Comment 19

[Cosmin Sabou [:CosminS]]

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=d8091d350d7c62ee1ee250a05df9ded6f5a43629&selectedJob=266885927&searchStr=Linting%2Copt%2Cpedantic%2Cchecks%2Csource-test-mozlint-license%2Cpedantic%28license%29

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=266885927&repo=autoland&lineNumber=227

Backout link: https://hg.mozilla.org/integration/autoland/rev/b47e17be584471f8033ca63aaff59efd3fc371ef

[task 2019-09-16T16:43:05.048Z] copying build/lib.linux-x86_64-2.7/psutil/_psutil_posix.so -> psutil
[task 2019-09-16T16:43:05.048Z]
[task 2019-09-16T16:43:05.048Z] Error processing command. Ignoring because optional. (optional:packages.txt:comm/build/virtualenv_packages.txt)
[task 2019-09-16T16:52:01.287Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/python/mozlint/test/files/foobar.js:0 | No matching license strings found in tools/lint/license/valid-licenses.txt (license)
[task 2019-09-16T16:52:01.287Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/python/mozlint/test/files/foobar.py:0 | No matching license strings found in tools/lint/license/valid-licenses.txt (license)
[task 2019-09-16T16:52:01.287Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/python/mozlint/test/files/no_foobar.js:0 | No matching license strings found in tools/lint/license/valid-licenses.txt (license)
[taskcluster 2019-09-16 16:52:01.647Z] === Task Finished ===
[taskcluster 2019-09-16 16:52:02.376Z] Unsuccessful task run with exit code: 1 completed in 789.243 seconds

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1e0061521d86
ride along: codespell Add support of exclude: r=ahal

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a0ba467e5d7a
Add a test to the mozlint check: license r=ahal

Comment 22

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/1e0061521d86
https://hg.mozilla.org/mozilla-central/rev/a0ba467e5d7a

Comment 23

[Sylvestre Ledru [:Sylvestre]]

Comment #19 fixed!
codespell, yaml, shellcheck, lintpref are missing.

Comment 24

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bcd5cfec8bb6
Add a test to the mozlint check: codespell r=ahal

Comment 25

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/bcd5cfec8bb6

Comment 26

[BugBot [:suhaib / :marco]]

The leave-open keyword is there and there is no activity for 6 months.
:Sylvestre, maybe it's time to close this bug?

Comment 27

[Sylvestre Ledru [:Sylvestre]]

Yeah, we are probably good, closing.