Open Bug 1579845 Opened 7 months ago Updated 4 months ago

Add unit tests for the various mozlint rules that we have

Categories

(Firefox Build System :: Lint and Formatting, task)

task
Not set

Tracking

(firefox71 affected)

REOPENED
mozilla71
Tracking Status
firefox71 --- affected

People

(Reporter: Sylvestre, Assigned: Sylvestre)

References

(Depends on 1 open bug)

Details

(Keywords: leave-open)

Attachments

(8 files)

No description provided.

Note, I'm in the process of converting mozlint to Python 3. So it might help to either:

A) Block on that to avoid extra conversion work (bug 1567642)
B) Make sure the tests are Python 3 compatible (you won't be able to test this unfortunately until the above lands)

Depends on: 1580321

ML now means Machine Learning for most people, we should be more explicit for new comers

Depends on D45449

Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/18f2c53f2f71
Add a test to the mozlint check: file-perm r=ahal
https://hg.mozilla.org/integration/autoland/rev/8b1d6ad6acdc
Add a test to the mozlint check: file-whitespace r=ahal
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9c621b8602f1
Ride along: Add the line number in the file whitespace lint r=ahal
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e864f41e1829
ride along: Strip codespell results r=ahal
https://hg.mozilla.org/integration/autoland/rev/b4a2b9704d61
ride along: treeherder: Rename ml to mozlint r=ahal

Other things are coming

Status: RESOLVED → REOPENED
Keywords: leave-open
Resolution: FIXED → ---
Assignee: nobody → sledru
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f698c4b34515
Add a test to the mozlint check: license r=ahal
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d8091d350d7c
Add a test to the mozlint check: license r=ahal

Fixed (I am ignoring the tests)

Flags: needinfo?(sledru)

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=d8091d350d7c62ee1ee250a05df9ded6f5a43629&selectedJob=266885927&searchStr=Linting%2Copt%2Cpedantic%2Cchecks%2Csource-test-mozlint-license%2Cpedantic%28license%29

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=266885927&repo=autoland&lineNumber=227

Backout link: https://hg.mozilla.org/integration/autoland/rev/b47e17be584471f8033ca63aaff59efd3fc371ef

[task 2019-09-16T16:43:05.048Z] copying build/lib.linux-x86_64-2.7/psutil/_psutil_posix.so -> psutil
[task 2019-09-16T16:43:05.048Z]
[task 2019-09-16T16:43:05.048Z] Error processing command. Ignoring because optional. (optional:packages.txt:comm/build/virtualenv_packages.txt)
[task 2019-09-16T16:52:01.287Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/python/mozlint/test/files/foobar.js:0 | No matching license strings found in tools/lint/license/valid-licenses.txt (license)
[task 2019-09-16T16:52:01.287Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/python/mozlint/test/files/foobar.py:0 | No matching license strings found in tools/lint/license/valid-licenses.txt (license)
[task 2019-09-16T16:52:01.287Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/python/mozlint/test/files/no_foobar.js:0 | No matching license strings found in tools/lint/license/valid-licenses.txt (license)
[taskcluster 2019-09-16 16:52:01.647Z] === Task Finished ===
[taskcluster 2019-09-16 16:52:02.376Z] Unsuccessful task run with exit code: 1 completed in 789.243 seconds

Flags: needinfo?(sledru)
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1e0061521d86
ride along: codespell Add support of exclude: r=ahal
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a0ba467e5d7a
Add a test to the mozlint check: license r=ahal

Comment #19 fixed!
codespell, yaml, shellcheck, lintpref are missing.

Flags: needinfo?(sledru)
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bcd5cfec8bb6
Add a test to the mozlint check: codespell r=ahal
You need to log in before you can comment on or make changes to this bug.