Closed Bug 1579850 Opened 2 months ago Closed 2 months ago

downloads API: Treat HTTP 204 (No Content) and HTTP 205 (Reset Content) as SERVER_BAD_CONTENT

Categories

(WebExtensions :: Compatibility, enhancement)

enhancement
Not set

Tracking

(firefox71 fixed)

RESOLVED FIXED
mozilla71
Tracking Status
firefox71 --- fixed

People

(Reporter: nmaier, Assigned: nmaier)

References

Details

Attachments

(1 file)

Treating HTTP 204 (No Content) and HTTP 205 (Reset Content) as SERVER_BAD_CONTENT will create parity with Chrome.

https://chromium.googlesource.com/chromium/src/+/3db5cac7eb02074bd79fb1bbde697fed9cf44f85/components/download/internal/common/download_utils.cc#130

It also is the right thing to do, as these status codes mark responses that do not actually contain any content that could reasonably be saved.

Thanks to Rob for pointing this out.

Assignee: nobody → maierman
Keywords: checkin-needed

Pushed by nbeleuzu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9336bba18082
Treat HTTP 204 and HTTP 205 as SERVER_BAD_CONTENT r=robwu

Keywords: checkin-needed

Thanks for the quick follow up and patch Nils!

Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
Flags: qe-verify-
Flags: in-testsuite+
You need to log in before you can comment on or make changes to this bug.