1579850 - downloads API: Treat HTTP 204 (No Content) and HTTP 205 (Reset Content) as SERVER_BAD_CONTENT

Status: RESOLVED FIXED

(WebExtensions :: Compatibility, enhancement)

Description

[Nils Maier [:nmaier]]

Treating HTTP 204 (No Content) and HTTP 205 (Reset Content) as SERVER_BAD_CONTENT will create parity with Chrome.

https://chromium.googlesource.com/chromium/src/+/3db5cac7eb02074bd79fb1bbde697fed9cf44f85/components/download/internal/common/download_utils.cc#130

It also is the right thing to do, as these status codes mark responses that do not actually contain any content that could reasonably be saved.

Thanks to Rob for pointing this out.

Comment 1

[Nils Maier [:nmaier]]

Attachment: Bug 1579850: Treat HTTP 204 and HTTP 205 as SERVER_BAD_CONTENT r?robwu

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9336bba18082
Treat HTTP 204 and HTTP 205 as SERVER_BAD_CONTENT r=robwu

Comment 3

[Rob Wu [:robwu]]

Thanks for the quick follow up and patch Nils!

Comment 4

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/9336bba18082