Closed Bug 1579913 Opened 5 years ago Closed 5 years ago

Inline Preview :Use CodeMirror Operations to improve performance

Categories

(DevTools :: Debugger, enhancement)

Product:
DevTools
Component:
Debugger
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(firefox71 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 71
Tracking Flags:
Tracking Status
firefox71 --- fixed

People

(Reporter: davidwalsh, Assigned: davidwalsh)

References

(Blocks 1 open bug)

Details

(Whiteboard: [debugger-mvp])

Attachments

(1 file)

Bug 1579913 - Use CodeMirror Operations to improve inline preview performance r=jlast
47 bytes, text/x-phabricator-request
Details | Review

The new inline preview feature would benefit from using CodeMirror operations.

Pushed by dwalsh@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/941fe2efca5d
Use CodeMirror Operations to improve inline preview performance r=jlast

Backed out changeset 941fe2efca5d (Bug 1579913) for ES lint failure on InlinePreviews.js

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=941fe2efca5d50f94e1693018256b32bf5a7f782&selectedJob=265765599

Backout link: https://hg.mozilla.org/integration/autoland/rev/911c3b74f8fe74d8c76395531bdf8df1620fa2a4

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=265765599&repo=autoland&lineNumber=70

[setup 2019-09-09T18:22:48.443Z] GECKO_PATH is /builds/worker/checkouts/gecko
[task 2019-09-09T18:22:48.443Z] executing ['bash', '-cx', 'cp -r /build/node_modules_eslint node_modules && ln -s ../tools/lint/eslint/eslint-plugin-mozilla node_modules && ln -s ../tools/lint/eslint/eslint-plugin-spidermonkey-js node_modules && ./mach lint -l eslint -f treeherder --quiet -f json:/builds/worker/mozlint.json\n']in /builds/worker/checkouts/gecko
[task 2019-09-09T18:22:48.446Z] + cp -r /build/node_modules_eslint node_modules
[task 2019-09-09T18:22:48.862Z] + ln -s ../tools/lint/eslint/eslint-plugin-mozilla node_modules
[task 2019-09-09T18:22:48.863Z] + ln -s ../tools/lint/eslint/eslint-plugin-spidermonkey-js node_modules
[task 2019-09-09T18:22:48.864Z] + ./mach lint -l eslint -f treeherder --quiet -f json:/builds/worker/mozlint.json
[task 2019-09-09T18:22:49.787Z] New python executable in /builds/worker/checkouts/gecko/obj-x86_64-pc-linux-gnu/_virtualenvs/init/bin/python2.7
[task 2019-09-09T18:22:49.787Z] Also creating executable in /builds/worker/checkouts/gecko/obj-x86_64-pc-linux-gnu/_virtualenvs/init/bin/python
[task 2019-09-09T18:22:51.536Z] Installing setuptools, pip, wheel...done.
[task 2019-09-09T18:22:52.672Z] running build_ext
[task 2019-09-09T18:22:52.672Z] building 'psutil._psutil_linux' extension
[task 2019-09-09T18:22:52.672Z] creating build
[task 2019-09-09T18:22:52.672Z] creating build/temp.linux-x86_64-2.7
[task 2019-09-09T18:22:52.672Z] creating build/temp.linux-x86_64-2.7/psutil
[task 2019-09-09T18:22:52.672Z] x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fno-strict-aliasing -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -fPIC -DPSUTIL_POSIX=1 -DPSUTIL_VERSION=543 -DPSUTIL_LINUX=1 -I/usr/include/python2.7 -c psutil/_psutil_common.c -o build/temp.linux-x86_64-2.7/psutil/_psutil_common.o
[task 2019-09-09T18:22:52.672Z] x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fno-strict-aliasing -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -fPIC -DPSUTIL_POSIX=1 -DPSUTIL_VERSION=543 -DPSUTIL_LINUX=1 -I/usr/include/python2.7 -c psutil/_psutil_posix.c -o build/temp.linux-x86_64-2.7/psutil/_psutil_posix.o
[task 2019-09-09T18:22:52.672Z] x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fno-strict-aliasing -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -fPIC -DPSUTIL_POSIX=1 -DPSUTIL_VERSION=543 -DPSUTIL_LINUX=1 -I/usr/include/python2.7 -c psutil/_psutil_linux.c -o build/temp.linux-x86_64-2.7/psutil/_psutil_linux.o
[task 2019-09-09T18:22:52.672Z] creating build/lib.linux-x86_64-2.7
[task 2019-09-09T18:22:52.672Z] creating build/lib.linux-x86_64-2.7/psutil
[task 2019-09-09T18:22:52.672Z] x86_64-linux-gnu-gcc -pthread -shared -Wl,-O1 -Wl,-Bsymbolic-functions -Wl,-Bsymbolic-functions -Wl,-z,relro -fno-strict-aliasing -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -Wl,-Bsymbolic-functions -Wl,-z,relro -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security build/temp.linux-x86_64-2.7/psutil/_psutil_common.o build/temp.linux-x86_64-2.7/psutil/_psutil_posix.o build/temp.linux-x86_64-2.7/psutil/_psutil_linux.o -o build/lib.linux-x86_64-2.7/psutil/_psutil_linux.so
[task 2019-09-09T18:22:52.672Z] building 'psutil._psutil_posix' extension
[task 2019-09-09T18:22:52.672Z] x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fno-strict-aliasing -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -fPIC -DPSUTIL_POSIX=1 -DPSUTIL_VERSION=543 -DPSUTIL_LINUX=1 -I/usr/include/python2.7 -c psutil/_psutil_common.c -o build/temp.linux-x86_64-2.7/psutil/_psutil_common.o
[task 2019-09-09T18:22:52.672Z] x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fno-strict-aliasing -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -fPIC -DPSUTIL_POSIX=1 -DPSUTIL_VERSION=543 -DPSUTIL_LINUX=1 -I/usr/include/python2.7 -c psutil/_psutil_posix.c -o build/temp.linux-x86_64-2.7/psutil/_psutil_posix.o
[task 2019-09-09T18:22:52.672Z] x86_64-linux-gnu-gcc -pthread -shared -Wl,-O1 -Wl,-Bsymbolic-functions -Wl,-Bsymbolic-functions -Wl,-z,relro -fno-strict-aliasing -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -Wl,-Bsymbolic-functions -Wl,-z,relro -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security build/temp.linux-x86_64-2.7/psutil/_psutil_common.o build/temp.linux-x86_64-2.7/psutil/_psutil_posix.o -o build/lib.linux-x86_64-2.7/psutil/_psutil_posix.so
[task 2019-09-09T18:22:52.672Z] copying build/lib.linux-x86_64-2.7/psutil/_psutil_linux.so -> psutil
[task 2019-09-09T18:22:52.672Z] copying build/lib.linux-x86_64-2.7/psutil/_psutil_posix.so -> psutil
[task 2019-09-09T18:22:52.672Z]
[task 2019-09-09T18:22:52.672Z] Error processing command. Ignoring because optional. (optional:packages.txt:comm/build/virtualenv_packages.txt)
[task 2019-09-09T18:38:14.479Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/devtools/client/debugger/src/components/Editor/InlinePreviews.js:45:1 | Delete ???? (prettier/prettier)
[task 2019-09-09T18:38:14.479Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/devtools/client/debugger/src/components/Editor/InlinePreviews.js:49:9 | Delete ?? (prettier/prettier)
[task 2019-09-09T18:38:14.479Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/devtools/client/debugger/src/components/Editor/InlinePreviews.js:50:1 | Delete ?? (prettier/prettier)
[task 2019-09-09T18:38:14.479Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/devtools/client/debugger/src/components/Editor/InlinePreviews.js:51:11 | Delete ?? (prettier/prettier)
[task 2019-09-09T18:38:14.479Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/devtools/client/debugger/src/components/Editor/InlinePreviews.js:52:9 | Delete ?? (prettier/prettier)
[task 2019-09-09T18:38:14.479Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/devtools/client/debugger/src/components/Editor/InlinePreviews.js:54:9 | Delete ?? (prettier/prettier)
[task 2019-09-09T18:38:14.479Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/devtools/client/debugger/src/components/Editor/InlinePreviews.js:55:1 | Delete ?? (prettier/prettier)
[task 2019-09-09T18:38:14.479Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/devtools/client/debugger/src/components/Editor/InlinePreviews.js:56:13 | Delete ?? (prettier/prettier)
[task 2019-09-09T18:38:14.479Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/devtools/client/debugger/src/components/Editor/InlinePreviews.js:57:1 | Delete ?? (prettier/prettier)
[task 2019-09-09T18:38:14.479Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/devtools/client/debugger/src/components/Editor/InlinePreviews.js:58:13 | Delete ?? (prettier/prettier)
[task 2019-09-09T18:38:14.479Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/devtools/client/debugger/src/components/Editor/InlinePreviews.js:59:1 | Delete ?? (prettier/prettier)
[task 2019-09-09T18:38:14.479Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/devtools/client/debugger/src/components/Editor/InlinePreviews.js:60:13 | Delete ?? (prettier/prettier)
[task 2019-09-09T18:38:14.479Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/devtools/client/debugger/src/components/Editor/InlinePreviews.js:61:11 | Delete ?? (prettier/prettier)
[task 2019-09-09T18:38:14.479Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/devtools/client/debugger/src/components/Editor/InlinePreviews.js:62:1 | Delete ?? (prettier/prettier)
[task 2019-09-09T18:38:14.479Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/devtools/client/debugger/src/components/Editor/InlinePreviews.js:63:1 | Delete ?? (prettier/prettier)
[taskcluster 2019-09-09 18:38:14.868Z] === Task Finished ===
[taskcluster 2019-09-09 18:38:15.901Z] Unsuccessful task run with exit code: 1 completed in 948.036 seconds

Flags: needinfo?(dwalsh)
Assignee: nobody → dwalsh
Blocks: dbg-71
Status: NEW → ASSIGNED
Whiteboard: [debugger-mvp]
Pushed by dwalsh@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/412d310db37a
Use CodeMirror Operations to improve inline preview performance r=jlast

https://hg.mozilla.org/mozilla-central/rev/412d310db37a

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox71: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71

David, when this fix did improve DAMP or we are otherwise confident about impact; is it low-risk enough to uplift?

Blocks: dbg-perf
Flags: needinfo?(dwalsh)

David, did this improve performance for the regression in bug 1578219?

Flags: needinfo?(dwalsh)

Slightly; I've landed https://phabricator.services.mozilla.com/D45606 and I just huddled with Jason and we found a few places in the inline preview actions we could improve perf -- I think this upcoming patch will be the most fruitful.

Flags: needinfo?(dwalsh)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: