Closed Bug 1579936 Opened 1 year ago Closed 1 year ago

WebExt API: Add browser.experiments.urlbar.isBrowserUpdateReadyToInstall call

Categories

(Firefox :: Address Bar, enhancement, P2)

enhancement
Points:
3

Tracking

()

RESOLVED FIXED
Firefox 72
Iteration:
72.2 - Nov 4 - 17
Tracking Status
firefox72 --- fixed

People

(Reporter: harry, Assigned: mak)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

This checks for available update and would usually be used in tandem with browser.app.updateBrowser.

See appUpdater.isApplied(); appUpdater.isPending(); appUpdater.isDownloading(); appUpdater.updateDisabledByPolicy().

Priority: -- → P2
Summary: WebExt API: Add browser.app.checkUpdates call → WebExt API: Add browser.experiments.app.checkUpdates call
Assignee: nobody → mak
Iteration: --- → 72.2 - Nov 4 - 17
No longer blocks: 1579933
Status: NEW → ASSIGNED
Summary: WebExt API: Add browser.experiments.app.checkUpdates call → WebExt API: Add browser.experiments.urlbar.checkUpdates call

I'm changing the API to isUpdateReadyToInstall, because that's what the mock-up shows. We should not start an update check, we should just point out that an update is already pending or applied, afaict (the text states "is downloaded and ready to install").

Summary: WebExt API: Add browser.experiments.urlbar.checkUpdates call → WebExt API: Add browser.experiments.urlbar.isUpdateReadyToInstall call

My understanding is that the add-on will check isUpdateReadyToInstall, if it's true it will show the intervention asking to apply the update (Bug 1579935)

(In reply to Marco Bonardo [:mak] from comment #2)

My understanding is that the add-on will check isUpdateReadyToInstall, if it's true it will show the intervention asking to apply the update

Yes. Taking a closer look, there are a few things we need according to the Scenarios section under Update Intervention in this doc: https://docs.google.com/document/d/1pN0y8TkadgeQHF3k-t-sPDWHkfXTyno7tjAQf-IUtU0/edit#heading=h.j3x1nhpkzmqv

  1. Need to know whether an update is staged (this bug)
  2. If an update is staged, need to be able to restart the browser
  3. If an update isn't staged, need to know whether the user is on the latest version

Bug 1579935 is about updateBrowser, but it really should be about point 2, restarting the browser. I'll comment there.

We don't have a bug for point 3. I'm not sure whether it's even possible, but I'll file a bug. We may need to fall back to the "Get the latest Firefox browser" fallback in the doc linked above.

(In reply to Drew Willcoxon :adw from comment #4)

We don't have a bug for point 3.

bug 1596258

Attachment #9108482 - Attachment description: Bug 1579936 - WebExt API: Add browser.experiments.urlbar.isUpdateReadyToInstall call r=adw,mixedpuppy → Bug 1579936 - WebExt API: Add browser.experiments.urlbar.isBrowserUpdateReadyToInstall. r=adw,mixedpuppy
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/0cc270168d08
WebExt API: Add browser.experiments.urlbar.isBrowserUpdateReadyToInstall. r=adw,mixedpuppy
Summary: WebExt API: Add browser.experiments.urlbar.isUpdateReadyToInstall call → WebExt API: Add browser.experiments.urlbar.isBrowserUpdateReadyToInstall call
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 72
You need to log in before you can comment on or make changes to this bug.