Closed
Bug 1579947
Opened 6 years ago
Closed 6 years ago
[Protection Report] text colour and spacing is incorrect
Categories
(Firefox :: Protections UI, enhancement, P1)
Tracking
()
RESOLVED
FIXED
Firefox 71
People
(Reporter: ewright, Assigned: ewright)
References
Details
(Whiteboard: [protection-report][skyline])
Attachments
(1 file)
|
47 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details | Review |
-
The text other than the headers of each card should not be black. Instead it should be
--in-content-deemphasized-textaka--grey-60. -
There should also be a greater
line-heighton each of the text areas, to let the text breathe.
| Assignee | ||
Updated•6 years ago
|
Assignee: nobody → ewright
Status: NEW → ASSIGNED
Updated•6 years ago
|
Priority: -- → P1
Updated•6 years ago
|
Whiteboard: [protection-report][triage] → [protection-report][skyline]
| Assignee | ||
Comment 1•6 years ago
|
||
Pushed by ewright@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5c1f8b49b5c5
Edit font sizes and colors to match the mock. r=johannh
Comment 3•6 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71
| Assignee | ||
Comment 4•6 years ago
|
||
Comment on attachment 9091838 [details]
Bug 1579947 - Edit font sizes and colors to match the mock.
Beta/Release Uplift Approval Request
- User impact if declined: Font sizing and color does not look exactly as desired.
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): simple CSS fix changing colors and line-heights
- String changes made/needed: none
Attachment #9091838 -
Flags: approval-mozilla-beta?
Comment 5•6 years ago
|
||
Comment on attachment 9091838 [details]
Bug 1579947 - Edit font sizes and colors to match the mock.
Visual fixups for the Protection Report. Approved for 70.0b8.
Attachment #9091838 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 6•6 years ago
|
||
| bugherder uplift | ||
status-firefox70:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•