Closed Bug 1579947 Opened 3 months ago Closed 3 months ago

[Protection Report] text colour and spacing is incorrect

Categories

(Firefox :: Protections UI, enhancement, P1)

71 Branch
enhancement

Tracking

()

RESOLVED FIXED
Firefox 71
Tracking Status
firefox70 --- fixed
firefox71 --- fixed

People

(Reporter: ewright, Assigned: ewright)

References

(Blocks 1 open bug)

Details

(Whiteboard: [protection-report][skyline])

Attachments

(1 file)

  • The text other than the headers of each card should not be black. Instead it should be
    --in-content-deemphasized-text aka --grey-60.

  • There should also be a greater line-height on each of the text areas, to let the text breathe.

Assignee: nobody → ewright
Status: NEW → ASSIGNED
Priority: -- → P1
Whiteboard: [protection-report][triage] → [protection-report][skyline]
Pushed by ewright@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5c1f8b49b5c5
Edit font sizes and colors to match the mock. r=johannh
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71

Comment on attachment 9091838 [details]
Bug 1579947 - Edit font sizes and colors to match the mock.

Beta/Release Uplift Approval Request

  • User impact if declined: Font sizing and color does not look exactly as desired.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): simple CSS fix changing colors and line-heights
  • String changes made/needed: none
Attachment #9091838 - Flags: approval-mozilla-beta?

Comment on attachment 9091838 [details]
Bug 1579947 - Edit font sizes and colors to match the mock.

Visual fixups for the Protection Report. Approved for 70.0b8.

Attachment #9091838 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.