1579988 - Fix usage of nsIDocShellTreeItem in nsDocShell::SetTitle

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect, P2)

Description

[Kannan Vijayan [:djvj]]

https://searchfox.org/mozilla-central/source/docshell/base/nsDocShell.cpp#5519

This code passes SetTitle information to the tree owner based on whether the current docshell is the top one (i.e. has no parent).

No other information is retrieved about parent docshells aside from their existence.

For Fission, this should be replaced by a check of the BrowsingContext tree for top-ness.

Comment 1

[Chris Peterson [:cpeterson]]

Kannan says replacing nsIDocShellTreeItem calls should block enabling Fission in Nightly (M6).

Comment 2

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

Can I take this? I have a (prototype) patch

Comment 3

[Kannan Vijayan [:djvj]]

@tetsuharu - absolutely. All the bugs were created to be picked up by anybody that was able to or wanted to fix them.

I've been using kmag and nika as reviewers for my patches. I'm not a DOM peer so I can't review unfortunately.

Comment 4

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

(In reply to Kannan Vijayan [:djvj] from comment #3)

@tetsuharu - absolutely. All the bugs were created to be picked up by anybody that was able to or wanted to fix them.

I've been using kmag and nika as reviewers for my patches. I'm not a DOM peer so I can't review unfortunately.

Thank you!

Comment 5

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

Attachment: Bug 1579988 - Fix usage of nsIDocShellTreeItem in nsDocShell::SetTitle.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f748822a58d0
Fix usage of nsIDocShellTreeItem in nsDocShell::SetTitle. r=kmag

Comment 7

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/f748822a58d0