158 - warning fix : ns/nsprpub/pr/tests/thruput.c

Status: VERIFIED FIXED

(NSPR :: NSPR, defect, P3)

Description

[Rick Osborne]

Created by Rick Osborne ([e-mail]) on Sunday, April 12, 1998 6:22:17 PM PDT
Additional Details :
(In the continuing quest to eliminate even compiler warnings
... )

Simple fix.  Initial streams is always positive and some
equality tests were done agains another unsigned, so I
changed it to unsigend to stave off the warnings.  Other
code only increments or converts from a command-line value. 
(You can''t have negative streams, anyway, unless maybe
you''re in Bizarro-nix.)

--- thruput.old.c       Wed Apr 08 17:55:15 1998
+++ thruput.c   Sun Apr 12 02:56:23 1998
@@ -53,3 +53,3 @@
static PRInt32 xport_buffer = -1;
-static PRInt32 initial_streams = 1;
+static PRUint32 initial_streams = 1; /* no negative,
eliminate a warning */
static PRInt32 buffer_size = BUFFER_SIZE;
Updated by Wan-Teh Chang ([e-mail]) on Friday, April 24, 1998 12:47:44 PM PDT
Additional Details :
Assigned the bug to myself.  Closed the bug.
This is fixed in ns/nsprpub/pr/tests/thruput.c,
revision 3.2.

Comment 1

[Terry Weissman]

NSPR now has its own Bugzilla product.  Moving this bug to the NSPR product.

Comment 2

[Jesse Ruderman]

reopening to mark as fixed

Comment 3

[Jesse Ruderman]

marking fixed.

Comment 4

[Brant Gurganus]

VERIFIED due to no changes in over a year