Closed Bug 1580002 Opened 4 years ago Closed 4 years ago

[Protection Report] Automatically scanned today should hide

Categories

(Firefox :: Protections UI, defect, P1)

Product:
Firefox
Component:
Protections UI
Version:
70 Branch
Platform:
All
Unspecified
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 71
Tracking Flags:
Tracking Status
firefox70 --- verified
firefox71 --- verified

People

(Reporter: ewright, Assigned: ewright)

References

Details

(Whiteboard: [protection-report][skyline])

Attachments

(1 file)

Bug 1580002 - Hide automatically scanned message when user is not subscribed to Monitor
47 bytes, text/x-phabricator-request
lizzard
: approval-mozilla-beta+
Details | Review

When the user is not signed up with Monitor the text that says
"Automatically scanned today" and icon should be hidden.
This bug appeared from Bug 1576562

Priority: -- → P1
Whiteboard: [protection-report][triage] → [protection-report][skyline]
Pushed by ewright@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/346dc5a8c9bf
Hide automatically scanned message when user is not subscribed to Monitor r=johannh

Comment on attachment 9091873 [details]
Bug 1580002 - Hide automatically scanned message when user is not subscribed to Monitor

Beta/Release Uplift Approval Request

  • User impact if declined: Piece of UI showing when it should not be
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): simple css fix to hide the element
  • String changes made/needed: none
Attachment #9091873 - Flags: approval-mozilla-beta?

https://hg.mozilla.org/mozilla-central/rev/346dc5a8c9bf

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox71: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71

Comment on attachment 9091873 [details]
Bug 1580002 - Hide automatically scanned message when user is not subscribed to Monitor

CSS fix, needed for Skyline. OK for uplift for beta 7.

Attachment #9091873 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Flags: qe-verify+
QA Whiteboard: [qa-triaged]

Confirmed issue with 71.0a1 (2019-09-09) on Windows 10.
Fix verified with 71.0a1 (2019-09-18) and 70.0b7 on Windows 10, Ubuntu 18.04, macOS 10.13.

Status: RESOLVED → VERIFIED
status-firefox70: fixed → verified
status-firefox71: fixed → verified
Flags: qe-verify+
Hardware: Unspecified → All
You need to log in before you can comment on or make changes to this bug.