1580077 - Performance metrics for GeckoView streaming

Status: RESOLVED FIXED

(Core :: Performance, enhancement, P1)

Description

[Benjamin De Kosnik [:bdekoz]]

Exfiltrate a subset of existing telemetry probes for adequately defining page load from gecko telemetry to fenix/android using the new glean/geckoview_streaming approach.

Comment 1

[Benjamin De Kosnik [:bdekoz]]

blocks 1566340

Comment 2

[Benjamin De Kosnik [:bdekoz]]

Hey Dexter, here is current state for the performance metrics.

Histograms.json
https://github.com/bdekoz/gecko/commit/f1a51aed317930358147d788a22d3030d05d77f1

metrics.yaml
https://github.com/bdekoz/gecko/commit/7a352fe25ee224cc4b105f1e68473627046a6a78

When I throw these into an arm64 build of Fenix nightly, and try to look at the pings, I'm not getting any joy.

See:
https://debug-ping-preview.firebaseapp.com/pings/performance-metrics

Any thoughts? I'm building nightly, and I tried Fenix.nightly and Fenix.performancetest binaries. Which seem like the right ones to test, aka nightly + telemetry enabled. When I scope about:support it looks like the right geckoview binaries are substituted.

But the metadata is pointing to this being the release channel, instead of nightly.

client_info/app_channel/release

If I can switch this, will the logged ping have the non_blank_paint metric?

Comment 3

[Alessio Placitelli [:Dexter]]

For reference: https://github.com/mozilla/glean_parser/issues/95

Comment 4

[Alessio Placitelli [:Dexter]]

(In reply to Benjamin De Kosnik [:bdekoz] from comment #2)

Any thoughts? I'm building nightly, and I tried Fenix.nightly and Fenix.performancetest binaries. Which seem like the right ones to test, aka nightly + telemetry enabled. When I scope about:support it looks like the right geckoview binaries are substituted.

Nothing looks wrong in the metrics files. I left a few comments there, but they are not responsible for metrics not showing up.

How are you making Android Components (and Fenix) use the GeckoView?

But the metadata is pointing to this being the release channel, instead of nightly.

client_info/app_channel/release

If I can switch this, will the logged ping have the non_blank_paint metric?

That's due to the way Fenix reports channel. It doesn't mean it's not using GeckoView nightly, but that it's using Fenix release. Should not be a problem, I think, as long as you're sure you're importing the right version of GeckoView.

Comment 5

[Benjamin De Kosnik [:bdekoz]]

clearning the needinfo flag for the build questions, as Alessio worked through that part with me last week

Comment 6

[Benjamin De Kosnik [:bdekoz]]

Attachment: data_review.md

Comment 7

[Benjamin De Kosnik [:bdekoz]]

Attachment: performance metrics exfiltration

WIP performance metrics exfiltration from GeckoView

Comment 8

[Chris H-C :chutten]

Comment on attachment 9101721 [details]
data_review.md

Please list the individuals responsible for the permanent monitoring of these metrics and resubmit for review. (I'll be on PTO until Tuesday, so if you need a review before, say, the end of next week then please request it from another Data Steward)

Comment 9

[Benjamin De Kosnik [:bdekoz]]

Attachment: data_review.md

Hey Chenxia, this is the data review with the changes that Chris requested. I believe that Histograms.json and metrics.yaml are now in sync, and that each metric now has an individual owner.

I also dropped two metrics that I'll add in a later patch: NETWORK_CACHE_SIZE and BFCACHE_PAGE_RESTORED.

Comment 10

[Benjamin De Kosnik [:bdekoz]]

Attachment: data_review.md

Hi Chris, here are the changes you requested for the performance team metrics. I believe all the metrics now have both an individual owner, and are also pointed at the correct mailing list. (And that the performance team is actually monitoring this list....)

Comment 11

[Chris H-C :chutten]

Comment on attachment 9105572 [details]
data_review.md

DATA COLLECTION REVIEW RESPONSE:

    Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes. This collection is Telemetry so is documented in its definitions file [Histograms.json](https://hg.mozilla.org/mozilla-central/file/tip/toolkit/components/telemetry/Histograms.json) and the [Probe Dictionary](https://telemetry.mozilla.org/probe-dictionary/).

It is also documented in [metrics.yaml](https://hg.mozilla.org/mozilla-central/file/tip/toolkit/components/telemetry/geckoview/streaming/metrics.yaml), and in the [metrics.md documentation in engine-gecko-nightly](https://github.com/mozilla-mobile/android-components/blob/master/components/browser/engine-gecko-nightly/docs/metrics.md).

    Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

    If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, the individual owners are responsible. Among them bdekoz, vgosu, ddamjaovic, and mnovotny.

    Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical.

    Is the data collection request for default-on or default-off?

Some are default on for all channels. Some are default on for pre-release channels only.

    Does the instrumentation include the addition of any new identifiers?

No.

    Is the data collection covered by the existing Firefox privacy notice?

Yes.

    Does there need to be a check-in in the future to determine whether to renew the data?

No. This collection is permanent.

---
Result: datareview+

Comment 12

[Benjamin De Kosnik [:bdekoz]]

Attachment: Bug 1580077 - Exfiltrate selected histograms for performance metrics via geckoview_streaming. r=chutten!

Comment 13

[Benjamin De Kosnik [:bdekoz]]

This looks ready to land so setting checkin-needed flag

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bdc62559f994
Exfiltrate selected histograms for performance metrics via geckoview_streaming. r=chutten

Comment 15

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/bdc62559f994